GODRIVER-3455 Fix linting issues

Author: prestonvasquez

bson/byte_slice_codec.go

@@ -12,11 +12,7 @@ import (
 )
 
 // byteSliceCodec is the Codec used for []byte values.
-type byteSliceCodec struct {
-	// encodeNilAsEmpty causes EncodeValue to marshal nil Go byte slices as empty BSON binary values
-	// instead of BSON null.
-	encodeNilAsEmpty bool
-}
+type byteSliceCodec struct{}
 
 // Assert that byteSliceCodec satisfies the typeDecoder interface, which allows it to be
 // used by collection type decoders (e.g. map, slice, etc) to set individual values in a

bson/default_value_encoders.go

@@ -190,7 +190,7 @@ func floatEncodeValueRF(_ EncodeContext, vw ValueWriter, val any) error {
 // floatEncodeValue is the ValueEncoderFunc for float types. this function is
 // used to decode "types" and "kinds" and therefore cannot be a wrapper for
 // reflection-free decoding in the default "type" case.
-func floatEncodeValue(ec EncodeContext, vw ValueWriter, val reflect.Value) error {
+func floatEncodeValue(_ EncodeContext, vw ValueWriter, val reflect.Value) error {
 	switch val.Kind() {
 	case reflect.Float32, reflect.Float64:
 		return vw.WriteDouble(val.Float())
@@ -664,7 +664,7 @@ func byteSliceEncodeValue(encodeNilAsEmpty bool) defaultValueEncoderFunc {
 	})
 }
 
-func timeEncodeValueRF(ec EncodeContext, vw ValueWriter, val any) error {
+func timeEncodeValueRF(_ EncodeContext, vw ValueWriter, val any) error {
 	tt, ok := val.(time.Time)
 	if !ok {
 		return ValueEncoderError{Name: "TimeEncodeValue", Types: []reflect.Type{tTime}, Received: reflect.ValueOf(val)}
@@ -678,7 +678,7 @@ func timeEncodeValue(ec EncodeContext, vw ValueWriter, val reflect.Value) error
 	return timeEncodeValueRF(ec, vw, val.Interface())
 }
 
-func coreArrayEncodeValueRF(ec EncodeContext, vw ValueWriter, val any) error {
+func coreArrayEncodeValueRF(_ EncodeContext, vw ValueWriter, val any) error {
 	arr, ok := val.(bsoncore.Array)
 	if !ok {
 		return ValueEncoderError{Name: "CoreArrayEncodeValue", Types: []reflect.Type{tCoreArray}, Received: reflect.ValueOf(val)}

bson/default_value_encoders_test.go

@@ -571,7 +571,7 @@ func TestDefaultValueEncoders(t *testing.T) {
 		{
 			"ByteSliceEncodeValue",
 			ValueEncoderFunc(byteSliceEncodeValue(false)),
-			reflectFreeValueEncoderFunc(byteSliceEncodeValueRF(false)),
+			byteSliceEncodeValueRF(false),
 			[]subtest{
 				{
 					"wrong type",

bson/registry.go

@@ -126,10 +126,6 @@ func (r *Registry) registerReflectFreeTypeEncoder(valueType reflect.Type, enc re
 	r.reflectFreeTypeEncoders.Store(valueType, enc)
 }
 
-func (r *Registry) storeReflectFreeTypeEncoder(rt reflect.Type, enc reflectFreeValueEncoder) reflectFreeValueEncoder {
-	return r.reflectFreeTypeEncoders.LoadOrStore(rt, enc)
-}
-
 // RegisterTypeDecoder registers the provided ValueDecoder for the provided type.
 //
 // The type will be used as provided, so a decoder can be registered for a type and a different