Skip to content

Commit ddc19ee

Browse files
committed
fix NPD
1 parent e7bd4b9 commit ddc19ee

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

x/mongo/driver/topology/topology.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,10 @@ func equalTopologies(topo1, topo2 description.Topology) bool {
824824
}
825825

826826
for _, server := range topoServers {
827-
otherServer := otherServers[server.Addr.String()]
827+
otherServer, ok := otherServers[server.Addr.String()]
828+
if !ok {
829+
return false
830+
}
828831

829832
if !driverutil.EqualServers(*server, *otherServer) {
830833
return false

x/mongo/driver/topology/topology_test.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,6 +1042,31 @@ func BenchmarkSelectServerFromDescription(b *testing.B) {
10421042
}
10431043
}
10441044

1045+
func TestEqualTopologies(t *testing.T) {
1046+
assert.True(t, equalTopologies(
1047+
description.Topology{
1048+
Servers: []description.Server{{
1049+
Addr: "127.0.0.1:27017",
1050+
}},
1051+
}, description.Topology{
1052+
Servers: []description.Server{{
1053+
Addr: "127.0.0.1:27017",
1054+
}},
1055+
},
1056+
))
1057+
assert.False(t, equalTopologies(
1058+
description.Topology{
1059+
Servers: []description.Server{{
1060+
Addr: "127.0.0.1:27017",
1061+
}},
1062+
}, description.Topology{
1063+
Servers: []description.Server{{
1064+
Addr: "127.0.0.2:27017",
1065+
}},
1066+
},
1067+
))
1068+
}
1069+
10451070
func BenchmarkEqualTopologies(b *testing.B) {
10461071
servers := make([]description.Server, 100)
10471072
for i := 0; i < len(servers); i++ {

0 commit comments

Comments
 (0)