Remove *Location in decoded time.Time values

GODRIVER-884

Change-Id: I1ef785f1ce1e9693e277d41c7a7b4672c411a551

Author: skriptble

bson/bsoncodec/bsoncodec_test.go

@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"reflect"
 	"testing"
+	"time"
 
 	"go.mongodb.org/mongo-driver/bson/bsonrw"
 	"go.mongodb.org/mongo-driver/bson/bsontype"
@@ -53,6 +54,13 @@ func noerr(t *testing.T, err error) {
 	}
 }
 
+func compareTime(t1, t2 time.Time) bool {
+	if t1.Location() != t2.Location() {
+		return false
+	}
+	return t1.Equal(t2)
+}
+
 func compareErrors(err1, err2 error) bool {
 	if err1 == nil && err2 == nil {
 		return true

bson/bsoncodec/default_value_decoders.go

@@ -614,7 +614,7 @@ func (dvd DefaultValueDecoders) TimeDecodeValue(dc DecodeContext, vr bsonrw.Valu
 		return ValueDecoderError{Name: "TimeDecodeValue", Types: []reflect.Type{tTime}, Received: val}
 	}
 
-	val.Set(reflect.ValueOf(time.Unix(dt/1000, dt%1000*1000000)))
+	val.Set(reflect.ValueOf(time.Unix(dt/1000, dt%1000*1000000).UTC()))
 	return nil
 }
 

bson/bsoncodec/default_value_decoders_test.go

@@ -2035,7 +2035,7 @@ func TestDefaultValueDecoders(t *testing.T) {
 		oids := []primitive.ObjectID{primitive.NewObjectID(), primitive.NewObjectID(), primitive.NewObjectID()}
 		var str = new(string)
 		*str = "bar"
-		now := time.Now().Truncate(time.Millisecond)
+		now := time.Now().Truncate(time.Millisecond).UTC()
 		murl, err := url.Parse("https://mongodb.com/random-url?hello=world")
 		if err != nil {
 			t.Errorf("Error parsing URL: %v", err)
@@ -2573,6 +2573,7 @@ func TestDefaultValueDecoders(t *testing.T) {
 						cmp.Comparer(compareDecimal128),
 						cmp.Comparer(compareNoPrivateFields),
 						cmp.Comparer(compareZeroTest),
+						cmp.Comparer(compareTime),
 					); diff != "" {
 						t.Errorf("difference:\n%s", diff)
 						t.Errorf("Values are not equal.\ngot: %#v\nwant:%#v", got, want)