Skip to content

Commit f6882ec

Browse files
GODRIVER-3445 transactions
1 parent c8d684b commit f6882ec

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

internal/integration/unified/unified_spec_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@ var (
1919
//spectest.TestPath(3, "unified-test-format", "valid-pass"),
2020
//spectest.TestPath(3, "versioned-api"),
2121
//spectest.TestPath(3, "crud", "unified"),
22-
spectest.TestPath(3, "change-streams", "unified"),
23-
//"change-streams",
24-
//"transactions/unified",
22+
//spectest.TestPath(3, "change-streams", "unified"),
23+
spectest.TestPath(3, "transactions", "unified"),
2524
//"load-balancers",
2625
//"collection-management",
2726
//"command-monitoring",

internal/spectest/skip.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,22 @@ var skipTests = map[string]string{
205205
// TODO(GODRIVER-3395): Ensure findOne does not set batchSize=1
206206
"TestUnifiedSpec/specifications/source/crud/tests/unified/find.json/Find_with_batchSize_equal_to_limit": "Implement GODRIVER-3395",
207207

208+
// TODO(GODRIVER-2016): Convert transactions spec tests to unified test format
209+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/error-labels.json/do_not_add_UnknownTransactionCommitResult_label_to_MaxTimeMSExpired_inside_transaction": "Implement GODRIVER-2016",
210+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/error-labels.json/do_not_add_UnknownTransactionCommitResult_label_to_MaxTimeMSExpired_inside_transactions": "Implement GODRIVER-2016",
211+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/error-labels.json/add_UnknownTransactionCommitResult_label_to_MaxTimeMSExpired": "Implement GODRIVER-2016",
212+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/error-labels.json/add_UnknownTransactionCommitResult_label_to_writeConcernError_MaxTimeMSExpired": "Implement GODRIVER-2016",
213+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/retryable-commit.json/commitTransaction_applies_majority_write_concern_on_retries": "Implement GODRIVER-2016",
214+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/run-command.json/run_command_with_secondary_read_preference_in_client_option_and_primary_read_preference_in_transaction_options": "Implement GODRIVER-2016",
215+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/transaction_options_inherited_from_client": "Implement GODRIVER-2016",
216+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/transaction_options_inherited_from_defaultTransactionOptions": "Implement GODRIVER-2016",
217+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/startTransaction_options_override_defaults": "Implement GODRIVER-2016",
218+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/defaultTransactionOptions_override_client_options": "Implement GODRIVER-2016",
219+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/readConcern_local_in_defaultTransactionOptions": "Implement GODRIVER-2016",
220+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/readPreference_inherited_from_client": "Implement GODRIVER-2016",
221+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/readPreference_inherited_from_defaultTransactionOptions": "Implement GODRIVER-2016",
222+
"TestUnifiedSpec/specifications/source/transactions/tests/unified/transaction-options.json/startTransaction_overrides_readPreference": "Implement GODRIVER-2016",
223+
208224
// GODRIVER-1773: This test runs a "find" with limit=4 and batchSize=3. It
209225
// expects batchSize values of three for the "find" and one for the
210226
// "getMore", but we send three for both.

0 commit comments

Comments
 (0)