Ensure write concern not sent when not supported

GODRIVER-668

Change-Id: Iaa4e686d86f2a35f043969f1db1889839f958e4f

Author: skriptble

x/network/command/create_indexes.go

@@ -50,13 +50,16 @@ func (ci *CreateIndexes) encode(desc description.SelectedServer) (*Write, error)
 	}
 	cmd = append(cmd, ci.Opts...)
 
-	return &Write{
-		Clock:        ci.Clock,
-		DB:           ci.NS.DB,
-		Command:      cmd,
-		WriteConcern: ci.WriteConcern,
-		Session:      ci.Session,
-	}, nil
+	write := &Write{
+		Clock:   ci.Clock,
+		DB:      ci.NS.DB,
+		Command: cmd,
+		Session: ci.Session,
+	}
+	if desc.WireVersion != nil && desc.WireVersion.Max >= 5 {
+		write.WriteConcern = ci.WriteConcern
+	}
+	return write, nil
 }
 
 // Decode will decode the wire message using the provided server description. Errors during decoding

x/network/command/create_indexes_test.go

@@ -0,0 +1,39 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongo-go-driver/mongo/writeconcern"
+	"github.com/mongodb/mongo-go-driver/x/network/description"
+)
+
+func TestCreateIndexes(t *testing.T) {
+	t.Run("Encode Write Concern for MaxWireVersion >= 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 5},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := CreateIndexes{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != wc {
+			t.Error("write concern should be added to write command, but is missing")
+		}
+	})
+	t.Run("Omit Write Concern for MaxWireVersion < 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 4},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := CreateIndexes{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != nil {
+			t.Error("write concern should be omitted from write command, but is present")
+		}
+	})
+}

x/network/command/drop_collection.go

@@ -44,13 +44,16 @@ func (dc *DropCollection) Encode(desc description.SelectedServer) (wiremessage.W
 func (dc *DropCollection) encode(desc description.SelectedServer) (*Write, error) {
 	cmd := bsonx.Doc{{"drop", bsonx.String(dc.Collection)}}
 
-	return &Write{
-		Clock:        dc.Clock,
-		WriteConcern: dc.WriteConcern,
-		DB:           dc.DB,
-		Command:      cmd,
-		Session:      dc.Session,
-	}, nil
+	write := &Write{
+		Clock:   dc.Clock,
+		DB:      dc.DB,
+		Command: cmd,
+		Session: dc.Session,
+	}
+	if desc.WireVersion != nil && desc.WireVersion.Max >= 5 {
+		write.WriteConcern = dc.WriteConcern
+	}
+	return write, nil
 }
 
 // Decode will decode the wire message using the provided server description. Errors during decoding

x/network/command/drop_collection_test.go

@@ -0,0 +1,39 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongo-go-driver/mongo/writeconcern"
+	"github.com/mongodb/mongo-go-driver/x/network/description"
+)
+
+func TestDropCollection(t *testing.T) {
+	t.Run("Encode Write Concern for MaxWireVersion >= 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 5},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropCollection{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != wc {
+			t.Error("write concern should be added to write command, but is missing")
+		}
+	})
+	t.Run("Omit Write Concern for MaxWireVersion < 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 4},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropCollection{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != nil {
+			t.Error("write concern should be omitted from write command, but is present")
+		}
+	})
+}

x/network/command/drop_database.go

@@ -43,13 +43,16 @@ func (dd *DropDatabase) Encode(desc description.SelectedServer) (wiremessage.Wir
 func (dd *DropDatabase) encode(desc description.SelectedServer) (*Write, error) {
 	cmd := bsonx.Doc{{"dropDatabase", bsonx.Int32(1)}}
 
-	return &Write{
-		Clock:        dd.Clock,
-		DB:           dd.DB,
-		Command:      cmd,
-		WriteConcern: dd.WriteConcern,
-		Session:      dd.Session,
-	}, nil
+	write := &Write{
+		Clock:   dd.Clock,
+		DB:      dd.DB,
+		Command: cmd,
+		Session: dd.Session,
+	}
+	if desc.WireVersion != nil && desc.WireVersion.Max >= 5 {
+		write.WriteConcern = dd.WriteConcern
+	}
+	return write, nil
 }
 
 // Decode will decode the wire message using the provided server description. Errors during decoding

x/network/command/drop_database_test.go

@@ -0,0 +1,39 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongo-go-driver/mongo/writeconcern"
+	"github.com/mongodb/mongo-go-driver/x/network/description"
+)
+
+func TestDropDatabase(t *testing.T) {
+	t.Run("Encode Write Concern for MaxWireVersion >= 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 5},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropDatabase{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != wc {
+			t.Error("write concern should be added to write command, but is missing")
+		}
+	})
+	t.Run("Omit Write Concern for MaxWireVersion < 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 4},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropDatabase{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != nil {
+			t.Error("write concern should be omitted from write command, but is present")
+		}
+	})
+}

x/network/command/drop_indexes.go

@@ -49,13 +49,16 @@ func (di *DropIndexes) encode(desc description.SelectedServer) (*Write, error) {
 	}
 	cmd = append(cmd, di.Opts...)
 
-	return &Write{
-		Clock:        di.Clock,
-		DB:           di.NS.DB,
-		Command:      cmd,
-		WriteConcern: di.WriteConcern,
-		Session:      di.Session,
-	}, nil
+	write := &Write{
+		Clock:   di.Clock,
+		DB:      di.NS.DB,
+		Command: cmd,
+		Session: di.Session,
+	}
+	if desc.WireVersion != nil && desc.WireVersion.Max >= 5 {
+		write.WriteConcern = di.WriteConcern
+	}
+	return write, nil
 }
 
 // Decode will decode the wire message using the provided server description. Errors during decoding

x/network/command/drop_indexes_test.go

@@ -0,0 +1,39 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongo-go-driver/mongo/writeconcern"
+	"github.com/mongodb/mongo-go-driver/x/network/description"
+)
+
+func TestDropIndexes(t *testing.T) {
+	t.Run("Encode Write Concern for MaxWireVersion >= 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 5},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropIndexes{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != wc {
+			t.Error("write concern should be added to write command, but is missing")
+		}
+	})
+	t.Run("Omit Write Concern for MaxWireVersion < 5", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 4},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := DropIndexes{WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != nil {
+			t.Error("write concern should be omitted from write command, but is present")
+		}
+	})
+}

x/network/command/find_one_delete.go

@@ -55,13 +55,16 @@ func (f *FindOneAndDelete) encode(desc description.SelectedServer) (*Write, erro
 	}
 	command = append(command, f.Opts...)
 
-	return &Write{
-		Clock:        f.Clock,
-		DB:           f.NS.DB,
-		Command:      command,
-		WriteConcern: f.WriteConcern,
-		Session:      f.Session,
-	}, nil
+	write := &Write{
+		Clock:   f.Clock,
+		DB:      f.NS.DB,
+		Command: command,
+		Session: f.Session,
+	}
+	if desc.WireVersion != nil && desc.WireVersion.Max >= 4 {
+		write.WriteConcern = f.WriteConcern
+	}
+	return write, nil
 }
 
 // Decode will decode the wire message using the provided server description. Errors during decoding

x/network/command/find_one_delete_test.go

@@ -0,0 +1,39 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/mongodb/mongo-go-driver/mongo/writeconcern"
+	"github.com/mongodb/mongo-go-driver/x/network/description"
+)
+
+func TestFindOneAndDelete(t *testing.T) {
+	t.Run("Encode Write Concern for MaxWireVersion >= 4", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 4},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := FindOneAndDelete{NS: Namespace{DB: "foo", Collection: "bar"}, WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != wc {
+			t.Error("write concern should be added to write command, but is missing")
+		}
+	})
+	t.Run("Omit Write Concern for MaxWireVersion < 4", func(t *testing.T) {
+		desc := description.SelectedServer{
+			Server: description.Server{
+				WireVersion: &description.VersionRange{Min: 0, Max: 3},
+			},
+		}
+		wc := writeconcern.New(writeconcern.WMajority())
+		cmd := FindOneAndDelete{NS: Namespace{DB: "foo", Collection: "bar"}, WriteConcern: wc}
+		write, err := cmd.encode(desc)
+		noerr(t, err)
+		if write.WriteConcern != nil {
+			t.Error("write concern should be omitted from write command, but is present")
+		}
+	})
+}