GODRIVER-3241 Move mock OPMSG deployment to the experimental package #1831
Conversation
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change Report./v2/x/mongo/driver/drivertestcompatible changesMockDeployment: added |
There was a problem hiding this comment.
The goal of this ticket is to move the deployment to the experimental package, and use it where needed internally. Allowing external users to mock a server, if they want. See here for a rough POC of the proposal: prestonvasquez@dd57d5b
| ) | ||
|
|
||
| func TestOPMSGMockDeployment(t *testing.T) { | ||
| var md *MockDeployment |
There was a problem hiding this comment.
Kept the unit test as a mock without actually connecting because the process of connecting with a mock deployment confused me, but if it would be better coverage to actually connect would definitely appreciate guidance
There was a problem hiding this comment.
We should test this using a client. For example:
md := NewMockDeployment()
opts := options.Client()
opts.Opts = append(opts.Opts, func(co *options.ClientOptions) error {
co.Deployment = md
return nil
})
client, err := mongo.Connect(opts)
require.NoError(t, err)
md.AddResponses(bson.D{{"ok", 1}})
err = client.Ping(context.Background(), nil)
require.NoError(t, err)
| ) | ||
|
|
||
| func TestOPMSGMockDeployment(t *testing.T) { | ||
| var md *MockDeployment |
There was a problem hiding this comment.
We should test this using a client. For example:
md := NewMockDeployment()
opts := options.Client()
opts.Opts = append(opts.Opts, func(co *options.ClientOptions) error {
co.Deployment = md
return nil
})
client, err := mongo.Connect(opts)
require.NoError(t, err)
md.AddResponses(bson.D{{"ok", 1}})
err = client.Ping(context.Background(), nil)
require.NoError(t, err)| func newMockDeployment(responses ...bson.D) *mockDeployment { | ||
| return &mockDeployment{ | ||
| // NewMockDeployment returns a mock driver.Deployment that responds with OP_MSG wire messages. | ||
| func NewMockDeployment(responses ...bson.D) *MockDeployment { |
There was a problem hiding this comment.
@joyjwang We should note in the comment that for most use cases it's better to test with an actual database.
CC: @matthewdale
2 participants
GODRIVER-3241
Summary
Background & Motivation