GODRIVER-3425 Reference ObjectIdAsHexString decoder option in exception message. #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
Contributor
API Change Report./v2/mongo/optionsincompatible changes(*ClientOptionsBuilder).SetDriverInfo: removed ./v2/x/mongo/driver/authincompatible changesHandshakeOptions.OuterLibraryName: removed ./v2/x/mongo/driver/operationincompatible changes(*Hello).OuterLibraryName: removed ./v2/x/mongo/driver/topologyincompatible changesWithOuterLibraryName: removed |
matthewdale
added
review-priority-urgent
matthewdale
previously approved these changes
Nov 20, 2024
Collaborator
matthewdale
left a comment
matthewdale
left a comment
There was a problem hiding this comment.
Looks good, with a suggestion. 👍
bson/string_codec.go
Outdated
Comment on lines
61
to
62
| msg := "decoding an object ID into a plain string is not supported " + | ||
| "(set Decoder.ObjectIDAsHexString to enable decoding as a hexadecimal representation)" |
Collaborator
There was a problem hiding this comment.
Optional: Use a const and slightly clearer wording.
Suggested change
| msg := "decoding an object ID into a plain string is not supported " + | |
| "(set Decoder.ObjectIDAsHexString to enable decoding as a hexadecimal representation)" | |
| const msg = "decoding an object ID into a string is not supported by default" + | |
| "(set Decoder.ObjectIDAsHexString to enable decoding as a hexadecimal string)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3425
Summary
Reference ObjectIdAsHexString decoder option in exception message.
Background & Motivation