GODRIVER-3481 Improve JSON tests for Binary Vector Subtype. #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
Contributor
API Change ReportNo changes found! |
prestonvasquez
previously approved these changes
Feb 19, 2025
bson/bson_binary_vector_spec_test.go
Outdated
Comment on lines
145
to
148
| "FLOAT32 with padding": errNonZeroVectorPadding.Error(), | ||
| "INT8 with padding": errNonZeroVectorPadding.Error(), | ||
| "Padding specified with no vector data PACKED_BIT": errNonZeroVectorPadding.Error(), | ||
| "Exceeding maximum padding PACKED_BIT": errVectorPaddingTooLarge.Error(), |
Member
There was a problem hiding this comment.
Suggest using a string literal, rather than referencing the errNonZeroVectorPadding and errVectorPaddingTooLarge variables in case the error variables is somehow changed.
prestonvasquez
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3481
Summary
Sync up with updates at mongodb/specifications@585b797
Background & Motivation