Skip to content

GODRIVER-3518: Test flexible numeric comparisons with $$lte #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouselena merged 6 commits into from
Jun 20, 2025
Merged

GODRIVER-3518: Test flexible numeric comparisons with $$lte #2106

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a6a75c2
lte test allows for doubles
zhouselena Jun 18, 2025
a45b827
Merge branch 'master' of github.com:zhouselena/mongo-go-driver into G…
zhouselena Jun 18, 2025
ffc1b65
convert values to float64 for comparison
zhouselena Jun 20, 2025
9ca1d2e
todo comment for GODRIVER-3594
zhouselena Jun 20, 2025
ef9eade
some cleanup
zhouselena Jun 20, 2025
6010021
Merge branch 'master' of github.com:zhouselena/mongo-go-driver into G…
zhouselena Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/integration/unified/matches.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ func evaluateSpecialComparison(ctx context.Context, assertionDoc bson.Raw, actua
return fmt.Errorf("expected lsid %v, got %v", expectedID, actualID)
}
case "$$lte":
if assertionVal.Type != bson.TypeInt32 && assertionVal.Type != bson.TypeInt64 {
return fmt.Errorf("expected assertionVal to be an Int32 or Int64 but got a %s", assertionVal.Type)
if assertionVal.Type != bson.TypeInt32 && assertionVal.Type != bson.TypeInt64 && assertionVal.Type != bson.TypeDouble {
return fmt.Errorf("expected assertionVal to be an Int32, Int64, or Double but got a %s", assertionVal.Type)
}
if actual.Type != bson.TypeInt32 && actual.Type != bson.TypeInt64 {
return fmt.Errorf("expected value to be an Int32 or Int64 but got a %s", actual.Type)
if actual.Type != bson.TypeInt32 && actual.Type != bson.TypeInt64 && assertionVal.Type != bson.TypeDouble {
return fmt.Errorf("expected value to be an Int32, Int64, or Double but got a %s", actual.Type)
}

// Numeric values can be compared even if their types are different (e.g. if expected is an int32 and actual
Expand Down
4 changes: 0 additions & 4 deletions internal/spectest/skip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import "testing"
// skipTests is a map of "fully-qualified test name" to "the reason for skipping
// the test".
var skipTests = map[string][]string{
// TODO(GODRIVER-3518): Test flexible numeric comparisons with $$lte
"Modifies $$lte operator test to also use floating point and Int64 types (GODRIVER-3518)": {
"TestUnifiedSpec/unified-test-format/tests/valid-pass/operator-lte.json/special_lte_matching_operator",
},

// SPEC-1403: This test checks to see if the correct error is thrown when auto
// encrypting with a server < 4.2. Currently, the test will fail because a
Expand Down
Loading