Skip to content

Commit 0f5ff83

Browse files
committed
A few more Java 6 stragglers
JAVA-2996
1 parent d7a61be commit 0f5ff83

File tree

6 files changed

+4
-45
lines changed

6 files changed

+4
-45
lines changed

driver-core/src/main/com/mongodb/connection/SslSettings.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ public Builder applyConnectionString(final ConnectionString connectionString) {
143143
* Create a new SSLSettings from the settings in this builder.
144144
*
145145
* @return a new SSL settings
146-
* @throws com.mongodb.MongoInternalException if enabled is true, invalidHostNameAllowed is false, and the {@code "java.version"}
147-
* system property starts with 1.6
148146
*/
149147
public SslSettings build() {
150148
return new SslSettings(this);

driver-core/src/test/functional/com/mongodb/ClusterFixture.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616

1717
package com.mongodb;
1818

19-
import com.mongodb.internal.async.AsyncBatchCursor;
2019
import com.mongodb.async.FutureResultCallback;
21-
import com.mongodb.internal.async.SingleResultCallback;
2220
import com.mongodb.connection.AsynchronousSocketChannelStreamFactory;
2321
import com.mongodb.connection.ClusterSettings;
2422
import com.mongodb.connection.ClusterType;
@@ -32,6 +30,8 @@
3230
import com.mongodb.connection.StreamFactory;
3331
import com.mongodb.connection.TlsChannelStreamFactoryFactory;
3432
import com.mongodb.connection.netty.NettyStreamFactory;
33+
import com.mongodb.internal.async.AsyncBatchCursor;
34+
import com.mongodb.internal.async.SingleResultCallback;
3535
import com.mongodb.internal.binding.AsyncClusterBinding;
3636
import com.mongodb.internal.binding.AsyncConnectionSource;
3737
import com.mongodb.internal.binding.AsyncReadBinding;
@@ -373,11 +373,7 @@ public static SslSettings getSslSettings() {
373373
}
374374

375375
public static SslSettings getSslSettings(final ConnectionString connectionString) {
376-
SslSettings.Builder builder = SslSettings.builder().applyConnectionString(connectionString);
377-
if (System.getProperty("java.version").startsWith("1.6.")) {
378-
builder.invalidHostNameAllowed(true);
379-
}
380-
return builder.build();
376+
return SslSettings.builder().applyConnectionString(connectionString).build();
381377
}
382378

383379
public static ServerAddress getPrimary() {

driver-core/src/test/functional/com/mongodb/internal/async/client/Fixture.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.mongodb.internal.async.client;
1818

19-
import com.mongodb.Block;
2019
import com.mongodb.ClusterFixture;
2120
import com.mongodb.ConnectionString;
2221
import com.mongodb.MongoClientSettings;
@@ -26,7 +25,6 @@
2625
import com.mongodb.MongoTimeoutException;
2726
import com.mongodb.async.FutureResultCallback;
2827
import com.mongodb.connection.AsynchronousSocketChannelStreamFactoryFactory;
29-
import com.mongodb.connection.SslSettings;
3028
import com.mongodb.connection.StreamFactoryFactory;
3129
import com.mongodb.connection.TlsChannelStreamFactoryFactory;
3230
import org.bson.Document;
@@ -63,14 +61,6 @@ public static MongoClientSettings getMongoClientSettings() {
6361
public static com.mongodb.MongoClientSettings.Builder getMongoClientBuilderFromConnectionString() {
6462
com.mongodb.MongoClientSettings.Builder builder = com.mongodb.MongoClientSettings.builder()
6563
.applyConnectionString(getConnectionString());
66-
if (System.getProperty("java.version").startsWith("1.6.")) {
67-
builder.applyToSslSettings(new Block<SslSettings.Builder>() {
68-
@Override
69-
public void apply(final SslSettings.Builder builder) {
70-
builder.invalidHostNameAllowed(true);
71-
}
72-
});
73-
}
7464
builder.streamFactoryFactory(getStreamFactoryFactory());
7565
return builder;
7666
}

driver-legacy/src/test/functional/com/mongodb/Fixture.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,7 @@ public static synchronized MongoClientURI getMongoClientURI() {
8181
}
8282

8383
public static synchronized MongoClientURI getMongoClientURI(final MongoClientOptions.Builder builder) {
84-
MongoClientURI mongoClientURI = null;
85-
String mongoURIString = getMongoClientURIString();
86-
if (System.getProperty("java.version").startsWith("1.6.")) {
87-
builder.sslInvalidHostNameAllowed(true);
88-
}
89-
90-
mongoClientURI = new MongoClientURI(mongoURIString, builder);
91-
return mongoClientURI;
84+
return new MongoClientURI(getMongoClientURIString(), builder);
9285
}
9386

9487
public static MongoClientOptions getOptions() {

driver-sync/src/test/functional/com/mongodb/client/Fixture.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import com.mongodb.client.internal.MongoClientImpl;
2525
import com.mongodb.connection.ServerDescription;
2626
import com.mongodb.connection.ServerSettings;
27-
import com.mongodb.connection.SslSettings;
2827

2928
import java.util.List;
3029
import java.util.concurrent.TimeUnit;
@@ -93,14 +92,6 @@ public void apply(final ServerSettings.Builder builder) {
9392
builder.minHeartbeatFrequency(MIN_HEARTBEAT_FREQUENCY_MS, TimeUnit.MILLISECONDS);
9493
}
9594
});
96-
if (System.getProperty("java.version").startsWith("1.6.")) {
97-
builder.applyToSslSettings(new Block<SslSettings.Builder>() {
98-
@Override
99-
public void apply(final SslSettings.Builder builder) {
100-
builder.invalidHostNameAllowed(true);
101-
}
102-
});
103-
}
10495
mongoClientSettings = builder.build();
10596
}
10697
return mongoClientSettings;

driver-sync/src/test/functional/com/mongodb/client/TransactionProseTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.mongodb.MongoClientSettings;
2121
import com.mongodb.MongoException;
2222
import com.mongodb.connection.SocketSettings;
23-
import com.mongodb.connection.SslSettings;
2423
import org.bson.Document;
2524
import org.junit.After;
2625
import org.junit.Before;
@@ -47,14 +46,6 @@ public void setUp() {
4746
assumeTrue(canRunTests());
4847
MongoClientSettings.Builder builder = MongoClientSettings.builder()
4948
.applyConnectionString(getMultiMongosConnectionString());
50-
if (System.getProperty("java.version").startsWith("1.6.")) {
51-
builder.applyToSslSettings(new Block<SslSettings.Builder>() {
52-
@Override
53-
public void apply(final SslSettings.Builder builder) {
54-
builder.invalidHostNameAllowed(true);
55-
}
56-
});
57-
}
5849

5950
client = MongoClients.create(MongoClientSettings.builder(builder.build())
6051
.applyToSocketSettings(new Block<SocketSettings.Builder>() {

0 commit comments

Comments
 (0)