JAVA-2815: Add UnknownTransactionCommitResult error label

Update UnknownTransactionCommitResult error labelling to reflect the
specification

Author: jyemin

driver-core/src/main/com/mongodb/operation/CommitTransactionOperation.java

@@ -17,14 +17,20 @@
 package com.mongodb.operation;
 
 import com.mongodb.MongoException;
+import com.mongodb.MongoNodeIsRecoveringException;
+import com.mongodb.MongoNotPrimaryException;
+import com.mongodb.MongoSocketException;
 import com.mongodb.MongoTimeoutException;
+import com.mongodb.MongoWriteConcernException;
 import com.mongodb.WriteConcern;
 import com.mongodb.async.SingleResultCallback;
 import com.mongodb.binding.AsyncWriteBinding;
 import com.mongodb.binding.WriteBinding;
 
+import java.util.List;
+
 import static com.mongodb.MongoException.UNKNOWN_TRANSACTION_COMMIT_RESULT_LABEL;
-import static com.mongodb.operation.CommandOperationHelper.isRetryableException;
+import static java.util.Arrays.asList;
 
 /**
  * An operation that commits a transaction.
@@ -66,11 +72,33 @@ public void onResult(final Void result, final Throwable t) {
     }
 
     private void addErrorLabels(final MongoException e) {
-        if (isRetryableException(e) || e instanceof MongoTimeoutException) {
+        if (shouldAddUnknownTransactionCommitResultLabel(e)) {
             e.addLabel(UNKNOWN_TRANSACTION_COMMIT_RESULT_LABEL);
         }
     }
 
+    private static final List<Integer> NON_RETRYABLE_WRITE_CONCERN_ERROR_CODES = asList(79, 100);
+
+    static boolean shouldAddUnknownTransactionCommitResultLabel(final Throwable t) {
+        if (!(t instanceof MongoException)) {
+            return false;
+        }
+
+        MongoException e = (MongoException) t;
+
+        if (e instanceof MongoSocketException || e instanceof MongoTimeoutException
+                || e instanceof MongoNotPrimaryException || e instanceof MongoNodeIsRecoveringException) {
+            return true;
+        }
+
+        if (e instanceof MongoWriteConcernException) {
+            return !NON_RETRYABLE_WRITE_CONCERN_ERROR_CODES.contains(e.getCode());
+        }
+
+        return false;
+    }
+
+
     @Override
     protected String getCommandName() {
         return "commitTransaction";

driver-core/src/test/resources/transactions/README.rst

@@ -140,9 +140,9 @@ Use as integration tests
 ========================
 
 Run a MongoDB replica set with a primary, a secondary, and an arbiter,
-server version 4.0 or later. (Including a secondary ensures that server
-selection in a transaction works properly. Including an arbiter helps ensure
-that no new bugs have been introduced related to arbiters.)
+**server version 4.0.0-rc4 or later**. (Including a secondary ensures that
+server selection in a transaction works properly. Including an arbiter helps
+ensure that no new bugs have been introduced related to arbiters.)
 
 Load each YAML (or JSON) file using a Canonical Extended JSON parser.
 
@@ -232,11 +232,6 @@ Then for each element in ``tests``:
      Primary read preference even when the MongoClient is configured with
      another read preference.
 
-TODO:
-
-- drivers MUST retry commit/abort, needs to use failpoint.
-- test writeConcernErrors
-
 Command-Started Events
 ``````````````````````