Skip to content

Commit 28b9727

Browse files
committed
Kotlin codecs - simplify if logic readability
Remove the negative assertion checks to improve readability. JAVA-5035
1 parent d4130cc commit 28b9727

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

bson-kotlin/src/main/kotlin/org/bson/codecs/kotlin/DataClassCodec.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ internal data class DataClassCodec<T : Any>(
133133
codecRegistry: CodecRegistry,
134134
types: List<Type> = emptyList()
135135
): Codec<R>? {
136-
return if (!kClass.isData) {
137-
null
138-
} else {
136+
return if (kClass.isData) {
139137
validateAnnotations(kClass)
140138
val primaryConstructor =
141139
kClass.primaryConstructor ?: throw CodecConfigurationException("No primary constructor for $kClass")
@@ -148,6 +146,8 @@ internal data class DataClassCodec<T : Any>(
148146
kParameter, computeFieldName(kParameter), getCodec(kParameter, typeMap, codecRegistry))
149147
}
150148
return DataClassCodec(kClass, primaryConstructor, propertyModels)
149+
} else {
150+
null
151151
}
152152
}
153153

bson-kotlinx/src/main/kotlin/org/bson/codecs/kotlinx/KotlinSerializerCodec.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ private constructor(
8585
serializersModule: SerializersModule = defaultSerializersModule,
8686
bsonConfiguration: BsonConfiguration = BsonConfiguration()
8787
): Codec<T>? {
88-
return if (!(kClass.isData || kClass.isValue || kClass.isSealed)) {
89-
null
90-
} else {
88+
return if (kClass.isData || kClass.isValue || kClass.isSealed) {
9189
try {
9290
create(kClass, kClass.serializer(), serializersModule, bsonConfiguration)
9391
} catch (exception: SerializationException) {
9492
null
9593
}
94+
} else {
95+
null
9696
}
9797
}
9898

0 commit comments

Comments
 (0)