[JAVA-270]: If authentication is on for a replica set, then most likely all writes will always fail once primary server dies

Author: agirbal

src/main/com/mongodb/DBPort.java

@@ -28,6 +28,8 @@
 
 /**
  * represents a Port to the database, which is effectively a single connection to a server
+ * Methods implemented at the port level should throw the raw exceptions like IOException,
+ * so that the connector above can make appropriate decisions on how to handle.
  * @author antoine
  */
 public class DBPort {
@@ -117,29 +119,23 @@ private synchronized Response go( OutMessage msg , DBCollection coll , boolean f
         }
     }
 
-    synchronized CommandResult getLastError( DB db , WriteConcern concern){
+    synchronized CommandResult getLastError( DB db , WriteConcern concern) throws IOException {
 	DBApiLayer dbAL = (DBApiLayer) db;
 	return runCommand( dbAL , concern.getCommand() );
     }
 
-    synchronized DBObject findOne( DB db , String coll , DBObject q ){
+    synchronized DBObject findOne( DB db , String coll , DBObject q ) throws IOException {
         OutMessage msg = OutMessage.query( db._mongo , 0 , db.getName() + "." + coll , 0 , -1 , q , null );
 
-        try {
-            Response res = go( msg , db.getCollection( coll ) );
-            if ( res.size() == 0 )
-                return null;
-            if ( res.size() > 1 )
-                throw new MongoInternalException( "something is wrong.  size:" + res.size() );
-            return res.get(0);
-        }
-        catch ( IOException ioe ){
-            throw new MongoException.Network( "DBPort.findOne failed" , ioe );
-        }
-        
+        Response res = go( msg , db.getCollection( coll ) );
+        if ( res.size() == 0 )
+            return null;
+        if ( res.size() > 1 )
+            throw new MongoInternalException( "something is wrong.  size:" + res.size() );
+        return res.get(0);
     }
 
-    synchronized CommandResult runCommand( DB db , DBObject cmd ) {
+    synchronized CommandResult runCommand( DB db , DBObject cmd ) throws IOException {
         DBObject res = findOne( db , "$cmd" , cmd );
         if ( res == null )
             throw new MongoInternalException( "something is wrong, no command result" );
@@ -173,7 +169,7 @@ synchronized CommandResult runCommand( String db , DBObject cmd ) {
     }
 
 
-    synchronized CommandResult tryGetLastError( DB db , long last, WriteConcern concern){
+    synchronized CommandResult tryGetLastError( DB db , long last, WriteConcern concern) throws IOException {
         if ( last != _calls )
             return null;
 
@@ -281,7 +277,7 @@ protected void close(){
         _socket = null;
     }
 
-    void checkAuth( DB db ){
+    void checkAuth( DB db ) throws IOException {
         if ( db._username == null ){
             if ( db._name.equals( "admin" ) )
                 return;

src/main/com/mongodb/DBTCPConnector.java

@@ -118,8 +118,12 @@ void _checkClosed(){
 
     WriteResult _checkWriteError( DB db , MyPort mp , DBPort port , WriteConcern concern )
         throws MongoException {
-
-        CommandResult e = port.runCommand( db , concern.getCommand() );
+        CommandResult e = null;
+        try {
+            e = port.runCommand( db , concern.getCommand() );
+        } catch ( IOException ioe ){
+            throw new MongoException.Network( ioe.getMessage() , ioe );
+        }
         mp.done( port );
 
         Object foo = e.get( "err" );
@@ -150,9 +154,9 @@ public WriteResult say( DB db , OutMessage m , WriteConcern concern , ServerAddr
 
         MyPort mp = _myPort.get();
         DBPort port = mp.get( true , false , hostNeeded );
-        port.checkAuth( db );
 
         try {
+            port.checkAuth( db );
             port.say( m );
             if ( concern.callGetLastError() ){
                 return _checkWriteError( db , mp , port , concern );
@@ -204,11 +208,10 @@ public Response call( DB db , DBCollection coll , OutMessage m , ServerAddress h
 
         final MyPort mp = _myPort.get();
         final DBPort port = mp.get( false , slaveOk, hostNeeded );
-        
-        port.checkAuth( db );
-        
+                
         Response res = null;
         try {
+            port.checkAuth( db );
             res = port.call( m , coll );
             mp.done( port );
             if ( res._responseTo != m.getId() )
@@ -398,8 +401,9 @@ void testMaster()
         try {
             p = _masterPortPool.get();
             p.runCommand( _mongo.getDB("admin") , new BasicDBObject( "nonce" , 1 ) );
-        }
-        finally {
+        } catch ( IOException ioe ){
+            throw new MongoException.Network( ioe.getMessage() , ioe );
+        } finally {
             _masterPortPool.done( p );
         }
     }

src/main/com/mongodb/ReplicaSetStatus.java

@@ -192,14 +192,12 @@ else if ( !_setName.equals( setName ) ){
 
                     // TODO: look at members
                 }
-            }
-
-            catch ( MongoException e ){
+            } catch ( MongoException e ){
                 if ( _setName != null ){
                     // this probably means the master is busy, so going to ignore
                 }
                 else {
-                    _logger.log( Level.SEVERE , "can't get intial config from node: " + _addr , e );
+                    _logger.log( Level.SEVERE , "can't get initial config from node: " + _addr , e );
                 }
             }
             catch ( Exception e ){

src/main/com/mongodb/WriteResult.java

@@ -2,6 +2,8 @@
 
 package com.mongodb;
 
+import java.io.IOException;
+
 
 /**
  *      Copyright (C) 2008 10gen Inc.
@@ -86,7 +88,12 @@ public synchronized CommandResult getLastError(WriteConcern concern){
 
         // here we dont have a satisfying result
         if ( _port != null ){
-            _lastErrorResult = _port.tryGetLastError( _db , _lastCall , (concern == null) ? new WriteConcern() : concern  );
+            try {
+                _lastErrorResult = _port.tryGetLastError( _db , _lastCall , (concern == null) ? new WriteConcern() : concern  );
+            } catch ( IOException ioe ){
+                throw new MongoException.Network( ioe.getMessage() , ioe );
+            }
+
             if (_lastErrorResult == null)
                 throw new IllegalStateException( "The connection may have been used since this write, cannot obtain a result" );
             _lastConcern = concern;