JAVA-2815: startTransaction should throw when write concern is unacknowledged

Author: jyemin

driver-async/src/main/com/mongodb/async/client/ClientSessionImpl.java

@@ -17,10 +17,12 @@
 package com.mongodb.async.client;
 
 import com.mongodb.ClientSessionOptions;
+import com.mongodb.MongoClientException;
 import com.mongodb.MongoException;
 import com.mongodb.MongoInternalException;
 import com.mongodb.ReadConcern;
 import com.mongodb.TransactionOptions;
+import com.mongodb.WriteConcern;
 import com.mongodb.async.SingleResultCallback;
 import com.mongodb.internal.session.BaseClientSessionImpl;
 import com.mongodb.internal.session.ServerSessionPool;
@@ -94,6 +96,13 @@ public void startTransaction(final TransactionOptions transactionOptions) {
         }
         getServerSession().advanceTransactionNumber();
         this.transactionOptions = TransactionOptions.merge(transactionOptions, getOptions().getDefaultTransactionOptions());
+        WriteConcern writeConcern = this.transactionOptions.getWriteConcern();
+        if (writeConcern == null) {
+            throw new MongoInternalException("Invariant violated.  Transaction options write concern can not be null");
+        }
+        if (!writeConcern.isAcknowledged()) {
+            throw new MongoClientException("Transactions do not support unacknowledged write concern");
+        }
     }
 
     @Override

driver-core/src/main/com/mongodb/TransactionOptions.java

@@ -19,7 +19,6 @@
 import com.mongodb.annotations.Immutable;
 import com.mongodb.lang.Nullable;
 
-import static com.mongodb.assertions.Assertions.isTrueArgument;
 import static com.mongodb.assertions.Assertions.notNull;
 
 /**
@@ -165,7 +164,6 @@ public Builder readConcern(@Nullable final ReadConcern readConcern) {
          */
         public Builder writeConcern(@Nullable final WriteConcern writeConcern) {
             this.writeConcern = writeConcern;
-            isTrueArgument("acknowledged write concern", writeConcern != null && writeConcern.isAcknowledged());
             return this;
         }
 

driver-sync/src/main/com/mongodb/client/internal/ClientSessionImpl.java

@@ -17,10 +17,12 @@
 package com.mongodb.client.internal;
 
 import com.mongodb.ClientSessionOptions;
+import com.mongodb.MongoClientException;
 import com.mongodb.MongoException;
 import com.mongodb.MongoInternalException;
 import com.mongodb.ReadConcern;
 import com.mongodb.TransactionOptions;
+import com.mongodb.WriteConcern;
 import com.mongodb.client.ClientSession;
 import com.mongodb.internal.session.BaseClientSessionImpl;
 import com.mongodb.internal.session.ServerSessionPool;
@@ -93,6 +95,13 @@ public void startTransaction(final TransactionOptions transactionOptions) {
         }
         getServerSession().advanceTransactionNumber();
         this.transactionOptions = TransactionOptions.merge(transactionOptions, getOptions().getDefaultTransactionOptions());
+        WriteConcern writeConcern = this.transactionOptions.getWriteConcern();
+        if (writeConcern == null) {
+            throw new MongoInternalException("Invariant violated.  Transaction options write concern can not be null");
+        }
+        if (!writeConcern.isAcknowledged()) {
+            throw new MongoClientException("Transactions do not support unacknowledged write concern");
+        }
     }
 
     @Override