Skip to content

Commit 3a213a8

Browse files
jyeminjyemin
committed
Extract common CommandMarker code to helper class
1 parent bb63b1c commit 3a213a8

File tree

5 files changed

+29
-52
lines changed

5 files changed

+29
-52
lines changed

‎driver-core/src/main/com/mongodb/internal/async/client/CommandMarker.java

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,18 @@
1616

1717
package com.mongodb.internal.async.client;
1818

19-
import com.mongodb.Block;
20-
import com.mongodb.ConnectionString;
2119
import com.mongodb.MongoClientException;
22-
import com.mongodb.MongoClientSettings;
2320
import com.mongodb.MongoTimeoutException;
2421
import com.mongodb.ReadConcern;
2522
import com.mongodb.ReadPreference;
26-
import com.mongodb.connection.ClusterSettings;
2723
import com.mongodb.internal.async.SingleResultCallback;
2824
import org.bson.RawBsonDocument;
2925

3026
import java.io.Closeable;
3127
import java.util.Map;
32-
import java.util.concurrent.TimeUnit;
3328

34-
import static com.mongodb.internal.capi.MongoCryptOptionsHelper.createMongocryptdSpawnArgs;
29+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongocryptdSpawnArgs;
30+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongocryptdClientSettings;
3531

3632
@SuppressWarnings("UseOfProcessBuilder")
3733
class CommandMarker implements Closeable {
@@ -50,24 +46,7 @@ class CommandMarker implements Closeable {
5046
} else {
5147
processBuilder = null;
5248
}
53-
54-
String connectionString;
55-
if (options.containsKey("mongocryptdURI")) {
56-
connectionString = (String) options.get("mongocryptdURI");
57-
} else {
58-
connectionString = "mongodb://localhost:27020";
59-
}
60-
61-
client = AsyncMongoClients.create(MongoClientSettings.builder()
62-
.applyConnectionString(new ConnectionString(connectionString))
63-
.applyToClusterSettings(new Block<ClusterSettings.Builder>() {
64-
@Override
65-
public void apply(final ClusterSettings.Builder builder) {
66-
builder.serverSelectionTimeout(1, TimeUnit.SECONDS);
67-
}
68-
})
69-
.build());
70-
49+
client = AsyncMongoClients.create(createMongocryptdClientSettings((String) options.get("mongocryptdURI")));
7150
}
7251
}
7352

‎driver-core/src/main/com/mongodb/internal/async/client/Crypts.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import javax.net.ssl.SSLContext;
2727
import java.security.NoSuchAlgorithmException;
2828

29-
import static com.mongodb.internal.capi.MongoCryptOptionsHelper.createMongoCryptOptions;
29+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongoCryptOptions;
3030

3131
public final class Crypts {
3232

‎driver-core/src/main/com/mongodb/internal/capi/MongoCryptOptionsHelper.java renamed to ‎driver-core/src/main/com/mongodb/internal/capi/MongoCryptHelper.java

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616

1717
package com.mongodb.internal.capi;
1818

19+
import com.mongodb.Block;
20+
import com.mongodb.ConnectionString;
1921
import com.mongodb.MongoClientException;
22+
import com.mongodb.MongoClientSettings;
23+
import com.mongodb.connection.ClusterSettings;
2024
import com.mongodb.crypt.capi.MongoAwsKmsProviderOptions;
2125
import com.mongodb.crypt.capi.MongoCryptOptions;
2226
import com.mongodb.crypt.capi.MongoLocalKmsProviderOptions;
@@ -26,8 +30,9 @@
2630
import java.util.ArrayList;
2731
import java.util.List;
2832
import java.util.Map;
33+
import java.util.concurrent.TimeUnit;
2934

30-
public final class MongoCryptOptionsHelper {
35+
public final class MongoCryptHelper {
3136

3237
public static MongoCryptOptions createMongoCryptOptions(final Map<String, Map<String, Object>> kmsProviders,
3338
final Map<String, BsonDocument> namespaceToLocalSchemaDocumentMap) {
@@ -75,6 +80,20 @@ public static List<String> createMongocryptdSpawnArgs(final Map<String, Object>
7580
return spawnArgs;
7681
}
7782

78-
private MongoCryptOptionsHelper(){
83+
public static MongoClientSettings createMongocryptdClientSettings(final String connectionString) {
84+
85+
return MongoClientSettings.builder()
86+
.applyConnectionString(new ConnectionString((connectionString != null)
87+
? connectionString : "mongodb://localhost:27020"))
88+
.applyToClusterSettings(new Block<ClusterSettings.Builder>() {
89+
@Override
90+
public void apply(final ClusterSettings.Builder builder) {
91+
builder.serverSelectionTimeout(1, TimeUnit.SECONDS);
92+
}
93+
})
94+
.build();
95+
}
96+
97+
private MongoCryptHelper() {
7998
}
8099
}

‎driver-sync/src/main/com/mongodb/client/internal/CommandMarker.java

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,21 @@
1616

1717
package com.mongodb.client.internal;
1818

19-
import com.mongodb.Block;
20-
import com.mongodb.ConnectionString;
2119
import com.mongodb.MongoClientException;
22-
import com.mongodb.MongoClientSettings;
2320
import com.mongodb.MongoException;
2421
import com.mongodb.MongoTimeoutException;
2522
import com.mongodb.ReadConcern;
2623
import com.mongodb.ReadPreference;
2724
import com.mongodb.client.MongoClient;
2825
import com.mongodb.client.MongoClients;
29-
import com.mongodb.connection.ClusterSettings;
3026
import org.bson.RawBsonDocument;
3127

3228
import java.io.Closeable;
3329
import java.io.IOException;
3430
import java.util.Map;
35-
import java.util.concurrent.TimeUnit;
3631

37-
import static com.mongodb.internal.capi.MongoCryptOptionsHelper.createMongocryptdSpawnArgs;
32+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongocryptdSpawnArgs;
33+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongocryptdClientSettings;
3834

3935
@SuppressWarnings("UseOfProcessBuilder")
4036
class CommandMarker implements Closeable {
@@ -52,24 +48,7 @@ class CommandMarker implements Closeable {
5248
} else {
5349
processBuilder = null;
5450
}
55-
56-
String connectionString;
57-
58-
if (options.containsKey("mongocryptdURI")) {
59-
connectionString = (String) options.get("mongocryptdURI");
60-
} else {
61-
connectionString = "mongodb://localhost:27020";
62-
}
63-
64-
client = MongoClients.create(MongoClientSettings.builder()
65-
.applyConnectionString(new ConnectionString(connectionString))
66-
.applyToClusterSettings(new Block<ClusterSettings.Builder>() {
67-
@Override
68-
public void apply(final ClusterSettings.Builder builder) {
69-
builder.serverSelectionTimeout(1, TimeUnit.SECONDS);
70-
}
71-
})
72-
.build());
51+
client = MongoClients.create(createMongocryptdClientSettings((String) options.get("mongocryptdURI")));
7352
}
7453
}
7554

‎driver-sync/src/main/com/mongodb/client/internal/Crypts.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import javax.net.ssl.SSLContext;
2828
import java.security.NoSuchAlgorithmException;
2929

30-
import static com.mongodb.internal.capi.MongoCryptOptionsHelper.createMongoCryptOptions;
30+
import static com.mongodb.internal.capi.MongoCryptHelper.createMongoCryptOptions;
3131

3232
public final class Crypts {
3333

0 commit comments

Comments
 (0)