[JAVA-263]: added NPE handling in rare edge case

agirbal · agirbal · commit 403d28d87b78 · 2011-02-16T23:11:28.000-08:00
diff --git a/src/main/com/mongodb/DBTCPConnector.java b/src/main/com/mongodb/DBTCPConnector.java
@@ -322,6 +322,12 @@ DBPort get( boolean keep , boolean slaveOk , ServerAddress hostNeeded ){
                 }
             }
 
+            if (_masterPortPool == null) {
+                // this should only happen in rare case that no master was ever found
+                // may get here at startup if it's a read, slaveOk=true, and ALL servers are down
+                throw new MongoException("Rare case where master=null, probably all servers are down");
+            }
+
             // use master
             DBPort p = _masterPortPool.get();
             if ( keep && _inRequest ) {

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,12 @@ DBPort get( boolean keep , boolean slaveOk , ServerAddress hostNeeded ){`
`322`	`322`	`}`
`323`	`323`	`}`
`324`	`324`
	`325`	`+ if (_masterPortPool == null) {`
	`326`	`+ // this should only happen in rare case that no master was ever found`
	`327`	`+ // may get here at startup if it's a read, slaveOk=true, and ALL servers are down`
	`328`	`+ throw new MongoException("Rare case where master=null, probably all servers are down");`
	`329`	`+ }`
	`330`	`+`
`325`	`331`	`// use master`
`326`	`332`	`DBPort p = _masterPortPool.get();`
`327`	`333`	`if ( keep && _inRequest ) {`