JAVA-1126: Factored expression into a final field

Author: jyemin

src/main/com/mongodb/DBCollectionImpl.java

@@ -537,13 +537,15 @@ private class OrderedRunGenerator implements Iterable<Run> {
         private final DBPort port;
         private final WriteConcern writeConcern;
         private final DBEncoder encoder;
+        private final int maxBatchWriteSize;
 
         public OrderedRunGenerator(final List<WriteRequest> writeRequests, final WriteConcern writeConcern, final DBEncoder encoder,
                                    final DBPort port) {
             this.writeRequests = writeRequests;
             this.port = port;
             this.writeConcern = writeConcern.continueOnError(false);
             this.encoder = encoder;
+            this.maxBatchWriteSize = db.getConnector().getServerDescription(port.getAddress()).getMaxWriteBatchSize();
         }
 
         @Override
@@ -570,8 +572,7 @@ public Run next() {
                 private int getStartIndexOfNextRun() {
                     WriteRequest.Type type = writeRequests.get(curIndex).getType();
                     for (int i = curIndex; i < writeRequests.size(); i++) {
-                        if (i == curIndex + db.getConnector().getServerDescription(port.getAddress()).getMaxWriteBatchSize()
-                            || writeRequests.get(i).getType() != type) {
+                        if (i == curIndex + maxBatchWriteSize || writeRequests.get(i).getType() != type) {
                             return i;
                         }
                     }
@@ -592,13 +593,15 @@ private class UnorderedRunGenerator implements Iterable<Run> {
         private final DBPort port;
         private final WriteConcern writeConcern;
         private final DBEncoder encoder;
+        private final int maxBatchWriteSize;
 
         public UnorderedRunGenerator(final List<WriteRequest> writeRequests, final WriteConcern writeConcern,
                                      final DBEncoder encoder, final DBPort port) {
             this.writeRequests = writeRequests;
             this.port = port;
             this.writeConcern = writeConcern.continueOnError(true);
             this.encoder = encoder;
+            this.maxBatchWriteSize = db.getConnector().getServerDescription(port.getAddress()).getMaxWriteBatchSize();
         }
 
         @Override
@@ -629,7 +632,7 @@ public Run next() {
                         }
                         run.add(writeRequest, curIndex);
                         curIndex++;
-                        if (run.size() > db.getConnector().getServerDescription(port.getAddress()).getMaxWriteBatchSize()) {
+                        if (run.size() > maxBatchWriteSize) {
                             return runs.remove(run.type);
                         }
                     }