Skip to content

Commit 54fdfe1

Browse files
author
Brendan W. McAdams
committed
Merge pull request #39 from kevinsawicki/stringbuilder
Use StringBuilder.append instead of += when building up a String.
2 parents ea4c085 + 40a2ae6 commit 54fdfe1

File tree

3 files changed

+24
-26
lines changed

3 files changed

+24
-26
lines changed

src/main/com/mongodb/DBCollection.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -458,16 +458,16 @@ DBObject defaultOptions( DBObject keys ){
458458
* @return a string representation of this index's fields
459459
*/
460460
public static String genIndexName( DBObject keys ){
461-
String name = "";
461+
StringBuilder name = new StringBuilder();
462462
for ( String s : keys.keySet() ){
463463
if ( name.length() > 0 )
464-
name += "_";
465-
name += s + "_";
464+
name.append( '_' );
465+
name.append( s ).append( '_' );
466466
Object val = keys.get( s );
467467
if ( val instanceof Number || val instanceof String )
468-
name += val.toString().replace( ' ' , '_' );
468+
name.append( val.toString().replace( ' ', '_' ) );
469469
}
470-
return name;
470+
return name.toString();
471471
}
472472

473473
// --- END INDEX CODE ---

src/main/com/mongodb/Mongo.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -693,16 +693,15 @@ public void run() {
693693

694694
@Override
695695
public String toString() {
696-
String str = "Mongo: ";
696+
StringBuilder str = new StringBuilder("Mongo: ");
697697
List<ServerAddress> list = getServerAddressList();
698698
if (list == null || list.isEmpty())
699-
str += "null";
699+
str.append("null");
700700
else {
701-
for (ServerAddress addr : list) {
702-
str += addr.toString() + ",";
703-
}
704-
str = str.substring(0, str.length() - 1);
701+
for ( ServerAddress addr : list )
702+
str.append( addr.toString() ).append( ',' );
703+
str.deleteCharAt( str.length() - 1 );
705704
}
706-
return str;
705+
return str.toString();
707706
}
708707
}

src/main/com/mongodb/util/Args.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,33 +45,32 @@ public String getOption( String name ){
4545
}
4646

4747
public String toString(){
48-
String s = "";
49-
48+
StringBuilder s = new StringBuilder();
49+
5050
for ( String p : _options.keySet() ){
51-
s += "-" + p;
51+
s.append( '-' ).append( p );
5252

5353
String v = _options.get( p );
5454
if ( v.length() == 0 )
5555
continue;
5656

57-
s += "=";
58-
57+
s.append( '=' );
58+
5959
if ( v.indexOf( " " ) >= 0 )
60-
s += "\"" + v + "\"";
60+
s.append( '"' ).append( v ).append( '"' );
6161
else
62-
s += v;
62+
s.append( v );
6363
}
6464

6565
for ( String p : _params ){
66-
s += " ";
66+
s.append( ' ' );
6767
if ( p.indexOf( " " ) >= 0 )
68-
s += "\"" + p + "\"";
69-
else
70-
s += p;
68+
s.append( '"' ).append( p ).append( '"' );
69+
else
70+
s.append( p );
7171
}
72-
73-
74-
return s;
72+
73+
return s.toString();
7574
}
7675

7776
final Map<String,String> _options = new HashMap<String,String>();

0 commit comments

Comments
 (0)