Skip to content

Commit c5fe552

Browse files
committed
Revert DBCollection.find requring notNull queries
Historically it has, so changing it breaks existing behaviour. JAVA-2322
1 parent 28eb7cc commit c5fe552

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

driver/src/main/com/mongodb/DBCursor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public DBCursor(final DBCollection collection, final DBObject query, final DBObj
103103
private DBCursor(final DBCollection collection, final DBObject filter, final DBCollectionFindOptions findOptions,
104104
final OperationExecutor executor, final DBDecoderFactory decoderFactory, final Decoder<DBObject> decoder) {
105105
this.collection = notNull("collection", collection);
106-
this.filter = notNull("filter", filter);
106+
this.filter = filter;
107107
this.executor = notNull("executor", executor);
108108
this.findOptions = notNull("findOptions", findOptions.copy());
109109
this.decoderFactory = decoderFactory;

driver/src/test/functional/com/mongodb/DBCollectionTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ public void testInsert() {
123123
assertEquals(new BasicDBObject("_id", 1).append("x", 2), collection.findOne());
124124
}
125125

126+
@Test
127+
public void testFindWithNullQuery() {
128+
collection.insert(new BasicDBObject("_id", 1).append("x", 2));
129+
assertEquals(new BasicDBObject("_id", 1).append("x", 2), collection.find(null).next());
130+
}
131+
126132
@Test
127133
public void testInsertDuplicateKeyException() {
128134
DBObject doc = new BasicDBObject("_id", 1);

0 commit comments

Comments
 (0)