Added missing Nullable annotations

JAVA-3719

Author: rozza

driver-core/src/main/com/mongodb/ConnectionString.java

@@ -1178,6 +1178,7 @@ public WriteConcern getWriteConcern() {
      * @since 3.9
      * @mongodb.server.release 3.6
      */
+    @Nullable
     public Boolean getRetryWritesValue() {
         return retryWrites;
     }
@@ -1189,6 +1190,7 @@ public Boolean getRetryWritesValue() {
      * @since 3.11
      * @mongodb.server.release 3.6
      */
+    @Nullable
     public Boolean getRetryReads() {
         return retryReads;
     }

driver-core/src/main/com/mongodb/MongoBulkWriteException.java

@@ -108,6 +108,7 @@ public List<BulkWriteError> getWriteErrors() {
      *
      * @return the write concern error
      */
+    @Nullable
     public WriteConcernError getWriteConcernError() {
         return writeConcernError;
     }

driver-core/src/main/com/mongodb/MongoClientSettings.java

@@ -210,8 +210,10 @@ public Builder applyConnectionString(final ConnectionString connectionString) {
             if (connectionString.getReadPreference() != null) {
                 readPreference = connectionString.getReadPreference();
             }
-            if (connectionString.getRetryWritesValue() != null) {
-                retryWrites = connectionString.getRetryWritesValue();
+
+            Boolean retryWritesValue = connectionString.getRetryWritesValue();
+            if (retryWritesValue != null) {
+                retryWrites = retryWritesValue;
             }
             if (connectionString.getUuidRepresentation() != null) {
                 uuidRepresentation = connectionString.getUuidRepresentation();

driver-core/src/main/com/mongodb/ReadConcernLevel.java

@@ -73,7 +73,7 @@ public enum ReadConcernLevel {
     }
 
     /**
-     * @return the String representation of the read concern level that the MongoDB server understands or null for the default
+     * @return the String representation of the read concern level that the MongoDB server understands
      */
     public String getValue() {
         return value;

driver-core/src/main/com/mongodb/WriteConcern.java

@@ -192,6 +192,7 @@ private WriteConcern(@Nullable final Object w, @Nullable final Integer wTimeoutM
      *
      * @return w, either an instance of Integer or String or null
      */
+    @Nullable
     public Object getWObject() {
         return w;
     }
@@ -239,6 +240,7 @@ public Integer getWTimeout(final TimeUnit timeUnit) {
      * @since 3.2
      * @mongodb.driver.manual core/write-concern/#journaled Journaled
      */
+    @Nullable
     public Boolean getJournal() {
         return journal;
     }
@@ -369,7 +371,7 @@ public WriteConcern withW(final String w) {
      * @since 3.2
      * @mongodb.driver.manual reference/write-concern/#j-option j option
      */
-    public WriteConcern withJournal(final Boolean journal) {
+    public WriteConcern withJournal(@Nullable final Boolean journal) {
         return new WriteConcern(w, wTimeoutMS, fsync, journal);
     }
 

driver-core/src/main/com/mongodb/connection/AsynchronousSocketChannelStreamFactory.java

@@ -19,6 +19,7 @@
 import com.mongodb.ServerAddress;
 import com.mongodb.internal.connection.AsynchronousSocketChannelStream;
 import com.mongodb.internal.connection.PowerOfTwoBufferPool;
+import com.mongodb.lang.Nullable;
 
 import java.nio.channels.AsynchronousChannelGroup;
 
@@ -54,7 +55,7 @@ public AsynchronousSocketChannelStreamFactory(final SocketSettings settings, fin
      * @since 3.6
      */
     public AsynchronousSocketChannelStreamFactory(final SocketSettings settings, final SslSettings sslSettings,
-                                                  final AsynchronousChannelGroup group) {
+                                                  @Nullable final AsynchronousChannelGroup group) {
         if (sslSettings.isEnabled()) {
             throw new UnsupportedOperationException("No SSL support in java.nio.channels.AsynchronousSocketChannel. For SSL support use "
                     + "com.mongodb.connection.TlsChannelStreamFactoryFactory");

driver-core/src/main/com/mongodb/connection/ClusterDescription.java

@@ -21,6 +21,7 @@
 import com.mongodb.annotations.Immutable;
 import com.mongodb.internal.selector.ReadPreferenceServerSelector;
 import com.mongodb.internal.selector.WritableServerSelector;
+import com.mongodb.lang.Nullable;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -138,6 +139,7 @@ public boolean isCompatibleWithDriver() {
      * @return a server in the cluster that is incompatibly older than the driver, or null if there are none
      * @since 3.6
      */
+    @Nullable
     public ServerDescription findServerIncompatiblyOlderThanDriver() {
         for (ServerDescription cur : serverDescriptions) {
             if (cur.isIncompatiblyOlderThanDriver()) {
@@ -153,6 +155,7 @@ public ServerDescription findServerIncompatiblyOlderThanDriver() {
      * @return a server in the cluster that is incompatibly newer than the driver, or null if there are none
      * @since 3.6
      */
+    @Nullable
     public ServerDescription findServerIncompatiblyNewerThanDriver() {
         for (ServerDescription cur : serverDescriptions) {
             if (cur.isIncompatiblyNewerThanDriver()) {
@@ -210,6 +213,7 @@ public ClusterType getType() {
      * @return any exception encountered while resolving the SRV record for the initial host, or null if none
      * @since 3.10
      */
+    @Nullable
     public MongoException getSrvResolutionException() {
         return srvResolutionException;
     }
@@ -231,18 +235,21 @@ public List<ServerDescription> getServerDescriptions() {
      * @mongodb.server.release 3.6
      * @since 3.6
      */
+    @Nullable
     public Integer getLogicalSessionTimeoutMinutes() {
         Integer retVal = null;
 
         for (ServerDescription cur : getServersByPredicate(this, serverDescription ->
                 serverDescription.isPrimary() || serverDescription.isSecondary())) {
-            if (cur.getLogicalSessionTimeoutMinutes() == null) {
+
+            Integer logicalSessionTimeoutMinutes = cur.getLogicalSessionTimeoutMinutes();
+            if (logicalSessionTimeoutMinutes == null) {
                 return null;
             }
             if (retVal == null) {
-                retVal = cur.getLogicalSessionTimeoutMinutes();
+                retVal = logicalSessionTimeoutMinutes;
             } else {
-                retVal = Math.min(retVal, cur.getLogicalSessionTimeoutMinutes());
+                retVal = Math.min(retVal, logicalSessionTimeoutMinutes);
             }
         }
         return retVal;

driver-core/src/main/com/mongodb/connection/ClusterSettings.java

@@ -24,6 +24,7 @@
 import com.mongodb.internal.connection.Cluster;
 import com.mongodb.internal.connection.ServerAddressHelper;
 import com.mongodb.internal.selector.LatencyMinimizingServerSelector;
+import com.mongodb.lang.Nullable;
 import com.mongodb.selector.CompositeServerSelector;
 import com.mongodb.selector.ServerSelector;
 
@@ -324,6 +325,7 @@ public ClusterSettings build() {
      * @return the SRV host, or null if none specified
      * @since 3.10
      */
+    @Nullable
     public String getSrvHost() {
         return srvHost;
     }
@@ -389,6 +391,7 @@ public String getRequiredReplicaSetName() {
      * @return the server selector, which may be null
      * @see Cluster#selectServer(com.mongodb.selector.ServerSelector)
      */
+    @Nullable
     public ServerSelector getServerSelector() {
         return serverSelector;
     }

driver-core/src/main/com/mongodb/connection/ConnectionId.java

@@ -17,6 +17,7 @@
 package com.mongodb.connection;
 
 import com.mongodb.annotations.Immutable;
+import com.mongodb.lang.Nullable;
 
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -63,7 +64,7 @@ public ConnectionId(final ServerId serverId) {
      * @see #withServerValue(int)
      * @since 3.11
      */
-    public ConnectionId(final ServerId serverId, final int localValue, final Integer serverValue) {
+    public ConnectionId(final ServerId serverId, final int localValue, @Nullable final Integer serverValue) {
         this.serverId = notNull("serverId", serverId);
         this.localValue = localValue;
         this.serverValue = serverValue;
@@ -109,6 +110,7 @@ public int getLocalValue() {
      *
      * @return the server generated id value for the connection or null if not set.
      */
+    @Nullable
     public Integer getServerValue() {
         return serverValue;
     }

driver-core/src/main/com/mongodb/connection/ServerDescription.java

@@ -129,6 +129,7 @@ public String getCanonicalAddress() {
      * @mongodb.server.release 3.6
      * @since 3.6
      */
+    @Nullable
     public Integer getLogicalSessionTimeoutMinutes() {
         return logicalSessionTimeoutMinutes;
     }
@@ -390,7 +391,7 @@ public Builder setVersion(final Integer setVersion) {
          * @since 3.4
          * @mongodb.server.release 3.4
          */
-        public Builder lastWriteDate(final Date lastWriteDate) {
+        public Builder lastWriteDate(@Nullable final Date lastWriteDate) {
             this.lastWriteDate = lastWriteDate;
             return this;
         }
@@ -417,7 +418,7 @@ public Builder lastUpdateTimeNanos(final long lastUpdateTimeNanos) {
          * @mongodb.server.release 3.6
          * @since 3.6
          */
-        public Builder logicalSessionTimeoutMinutes(final Integer logicalSessionTimeoutMinutes) {
+        public Builder logicalSessionTimeoutMinutes(@Nullable final Integer logicalSessionTimeoutMinutes) {
             this.logicalSessionTimeoutMinutes = logicalSessionTimeoutMinutes;
             return this;
         }
@@ -643,6 +644,7 @@ public int getMaxWireVersion() {
      *
      * @return the electionId, which may be null
      */
+    @Nullable
     public ObjectId getElectionId() {
         return electionId;
     }
@@ -652,6 +654,7 @@ public ObjectId getElectionId() {
      *
      * @return the setVersion, which may be null
      */
+    @Nullable
     public Integer getSetVersion() {
         return setVersion;
     }
@@ -759,6 +762,7 @@ public long getRoundTripTimeNanos() {
      *
      * @return the exception, which may be null
      */
+    @Nullable
     public Throwable getException() {
         return exception;
     }