Skip to content

Commit f90c8b2

Browse files
cleanup Mongo.Holder
1 parent d8547e2 commit f90c8b2

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

src/main/com/mongodb/Mongo.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818

1919
package com.mongodb;
2020

21-
import java.net.*;
21+
import java.net.UnknownHostException;
2222
import java.util.*;
23-
import java.util.Map.Entry;
24-
import java.util.concurrent.*;
23+
import java.util.concurrent.ConcurrentHashMap;
24+
import java.util.concurrent.ConcurrentMap;
2525

26-
import org.bson.io.*;
26+
import org.bson.io.PoolOutputBuffer;
2727

2828
/**
2929
* A database connection with internal pooling.
@@ -605,9 +605,11 @@ String _toKey( MongoURI uri ){
605605
buf.append( uri.getUsername() );
606606
return buf.toString();
607607
}
608+
609+
public static Holder singleton() { return _default; }
608610

609-
610-
private static final ConcurrentMap<String,Mongo> _mongos = new ConcurrentHashMap<String,Mongo>();
611+
private static Holder _default = new Holder();
612+
private final ConcurrentMap<String,Mongo> _mongos = new ConcurrentHashMap<String,Mongo>();
611613

612614
}
613615

src/test/com/mongodb/JavaClientTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package com.mongodb;
1919

2020
import java.io.IOException;
21+
import java.net.UnknownHostException;
2122
import java.nio.ByteBuffer;
2223
import java.util.*;
2324
import java.util.regex.Pattern;
@@ -785,7 +786,14 @@ public void testAllTypes(){
785786
DBObject b = c.findOne();
786787
assertTrue(a.equals(b));
787788
}
789+
790+
@Test
791+
public void testMongoHolder() throws MongoException, UnknownHostException {
792+
Mongo m1 = Mongo.Holder.singleton().connect( new MongoURI( "mongodb://localhost" ) );
793+
Mongo m2 = Mongo.Holder.singleton().connect( new MongoURI( "mongodb://localhost" ) );
788794

795+
assertEquals( m1, m2);
796+
}
789797
final Mongo _mongo;
790798
final DB _db;
791799

0 commit comments

Comments
 (0)