Skip to content

Commit 4bcf76f

Browse files
committed
Ensure only a single task is created
KAFKA-62
1 parent 276c433 commit 4bcf76f

File tree

5 files changed

+159
-13
lines changed

5 files changed

+159
-13
lines changed

src/integrationTest/java/com/mongodb/kafka/connect/embedded/EmbeddedKafka.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public void beforeAll(final ExtensionContext context) throws Exception {
238238

239239
@Override
240240
public void afterEach(final ExtensionContext context) throws InterruptedException {
241-
deleteTopicsAndWait(Duration.ofMinutes(2));
241+
deleteTopicsAndWait(Duration.ofMinutes(4));
242242
deleteSinkConnector();
243243
deleteSourceConnector();
244244
}

src/main/java/com/mongodb/kafka/connect/MongoSinkConnector.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818

1919
package com.mongodb.kafka.connect;
2020

21-
import java.util.ArrayList;
21+
import static java.util.Collections.singletonList;
22+
2223
import java.util.List;
2324
import java.util.Map;
2425

@@ -49,11 +50,7 @@ public Class<? extends Task> taskClass() {
4950

5051
@Override
5152
public List<Map<String, String>> taskConfigs(final int maxTasks) {
52-
List<Map<String, String>> taskConfigs = new ArrayList<>(maxTasks);
53-
for (int i = 0; i < maxTasks; i++) {
54-
taskConfigs.add(settings);
55-
}
56-
return taskConfigs;
53+
return singletonList(settings);
5754
}
5855

5956
@Override

src/main/java/com/mongodb/kafka/connect/MongoSourceConnector.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616

1717
package com.mongodb.kafka.connect;
1818

19-
import java.util.ArrayList;
19+
import static java.util.Collections.singletonList;
20+
2021
import java.util.List;
2122
import java.util.Map;
2223

@@ -43,11 +44,7 @@ public Class<? extends Task> taskClass() {
4344

4445
@Override
4546
public List<Map<String, String>> taskConfigs(final int maxTasks) {
46-
List<Map<String, String>> taskConfigs = new ArrayList<>(maxTasks);
47-
for (int i = 0; i < maxTasks; i++) {
48-
taskConfigs.add(settings);
49-
}
50-
return taskConfigs;
47+
return singletonList(settings);
5148
}
5249

5350
@Override
Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
/*
2+
* Copyright 2008-present MongoDB, Inc.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*
16+
* Original Work: Apache License, Version 2.0, Copyright 2017 Hans-Peter Grahsl.
17+
*/
18+
19+
package com.mongodb.kafka.connect;
20+
21+
import static org.junit.jupiter.api.Assertions.assertEquals;
22+
23+
import java.util.HashMap;
24+
import java.util.List;
25+
import java.util.Map;
26+
27+
import org.junit.jupiter.api.DisplayName;
28+
import org.junit.jupiter.api.Test;
29+
import org.junit.platform.runner.JUnitPlatform;
30+
import org.junit.runner.RunWith;
31+
32+
import com.mongodb.kafka.connect.sink.MongoSinkConfig;
33+
import com.mongodb.kafka.connect.sink.MongoSinkTask;
34+
35+
@RunWith(JUnitPlatform.class)
36+
class MongoSinkConnnectorTest {
37+
38+
@Test
39+
@DisplayName("Should return the expected version")
40+
void testVersion() {
41+
MongoSinkConnector sinkConnector = new MongoSinkConnector();
42+
43+
assertEquals(Versions.VERSION, sinkConnector.version());
44+
}
45+
46+
@Test
47+
@DisplayName("test task class")
48+
void testTaskClass() {
49+
MongoSinkConnector sinkConnector = new MongoSinkConnector();
50+
51+
assertEquals(MongoSinkTask.class, sinkConnector.taskClass());
52+
}
53+
54+
@Test
55+
@DisplayName("test task configs")
56+
void testConfig() {
57+
MongoSinkConnector sinkConnector = new MongoSinkConnector();
58+
59+
assertEquals(MongoSinkConfig.CONFIG, sinkConnector.config());
60+
}
61+
62+
@Test
63+
@DisplayName("test task configs")
64+
void testTaskConfigs() {
65+
MongoSinkConnector sinkConnector = new MongoSinkConnector();
66+
Map<String, String> configMap = new HashMap<String, String>() {{
67+
put("a", "1");
68+
put("b", "2");
69+
}};
70+
sinkConnector.start(configMap);
71+
List<Map<String, String>> taskConfigs = sinkConnector.taskConfigs(100);
72+
73+
assertEquals(1, taskConfigs.size());
74+
assertEquals(configMap, taskConfigs.get(0));
75+
}
76+
}
Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
/*
2+
* Copyright 2008-present MongoDB, Inc.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*
16+
* Original Work: Apache License, Version 2.0, Copyright 2017 Hans-Peter Grahsl.
17+
*/
18+
19+
package com.mongodb.kafka.connect;
20+
21+
import static org.junit.jupiter.api.Assertions.assertEquals;
22+
23+
import java.util.HashMap;
24+
import java.util.List;
25+
import java.util.Map;
26+
27+
import org.junit.jupiter.api.DisplayName;
28+
import org.junit.jupiter.api.Test;
29+
import org.junit.platform.runner.JUnitPlatform;
30+
import org.junit.runner.RunWith;
31+
32+
import com.mongodb.kafka.connect.source.MongoSourceConfig;
33+
import com.mongodb.kafka.connect.source.MongoSourceTask;
34+
35+
@RunWith(JUnitPlatform.class)
36+
class MongoSourceConnnectorTest {
37+
38+
@Test
39+
@DisplayName("Should return the expected version")
40+
void testVersion() {
41+
MongoSourceConnector sourceConnector = new MongoSourceConnector();
42+
43+
assertEquals(Versions.VERSION, sourceConnector.version());
44+
}
45+
46+
@Test
47+
@DisplayName("test task class")
48+
void testTaskClass() {
49+
MongoSourceConnector sourceConnector = new MongoSourceConnector();
50+
51+
assertEquals(MongoSourceTask.class, sourceConnector.taskClass());
52+
}
53+
54+
@Test
55+
@DisplayName("test task configs")
56+
void testConfig() {
57+
MongoSourceConnector sourceConnector = new MongoSourceConnector();
58+
59+
assertEquals(MongoSourceConfig.CONFIG, sourceConnector.config());
60+
}
61+
62+
@Test
63+
@DisplayName("test task configs")
64+
void testTaskConfigs() {
65+
MongoSourceConnector sourceConnector = new MongoSourceConnector();
66+
Map<String, String> configMap = new HashMap<String, String>() {{
67+
put("a", "1");
68+
put("b", "2");
69+
}};
70+
sourceConnector.start(configMap);
71+
List<Map<String, String>> taskConfigs = sourceConnector.taskConfigs(100);
72+
73+
assertEquals(1, taskConfigs.size());
74+
assertEquals(configMap, taskConfigs.get(0));
75+
}
76+
}

0 commit comments

Comments
 (0)