Use string.replace when trying to correct poorly escaped json

rozza · rozza · commit a541fa8f8296 · 2021-02-08T11:08:47.000Z
diff --git a/src/main/java/com/mongodb/kafka/connect/util/ConfigHelper.java b/src/main/java/com/mongodb/kafka/connect/util/ConfigHelper.java
@@ -59,7 +59,7 @@ public static Optional<Document> documentFromString(
           throw originalError;
         } else {
           return documentFromString(
-              jsonDocument.replaceAll("\\\\", "\\\\\\\\"),
+              jsonDocument.replace("\\", "\\\\"),
               new ConfigException("Not a valid JSON document", e));
         }
       }
@@ -80,8 +80,7 @@ private static Optional<List<Document>> jsonArrayFromString(
           throw originalError;
         } else {
           return jsonArrayFromString(
-              jsonArray.replaceAll("\\\\", "\\\\\\\\"),
-              new ConfigException("Not a valid JSON array", e));
+              jsonArray.replace("\\", "\\\\"), new ConfigException("Not a valid JSON array", e));
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public static Optional<Document> documentFromString(`
`59`	`59`	`throw originalError;`
`60`	`60`	`} else {`
`61`	`61`	`return documentFromString(`
`62`		`- jsonDocument.replaceAll("\\\\", "\\\\\\\\"),`
	`62`	`+ jsonDocument.replace("\\", "\\\\"),`
`63`	`63`	`new ConfigException("Not a valid JSON document", e));`
`64`	`64`	`}`
`65`	`65`	`}`
`@@ -80,8 +80,7 @@ private static Optional<List<Document>> jsonArrayFromString(`
`80`	`80`	`throw originalError;`
`81`	`81`	`} else {`
`82`	`82`	`return jsonArrayFromString(`
`83`		`- jsonArray.replaceAll("\\\\", "\\\\\\\\"),`
`84`		`- new ConfigException("Not a valid JSON array", e));`
	`83`	`+ jsonArray.replace("\\", "\\\\"), new ConfigException("Not a valid JSON array", e));`
`85`	`84`	`}`
`86`	`85`	`}`
`87`	`86`	`}`