PHPC-901: False slaveOk URI option should be ignored

Author: jmikola

php_phongo.c

@@ -1081,7 +1081,7 @@ static bool php_phongo_apply_rp_options_to_uri(mongoc_uri_t *uri, bson_t *option
 
 	new_rp = mongoc_read_prefs_copy(old_rp);
 
-	if (bson_iter_init_find_case(&iter, options, "slaveok") && BSON_ITER_HOLDS_BOOL(&iter)) {
+	if (bson_iter_init_find_case(&iter, options, "slaveok") && BSON_ITER_HOLDS_BOOL(&iter) && bson_iter_bool(&iter)) {
 		mongoc_read_prefs_set_mode(new_rp, MONGOC_READ_SECONDARY_PREFERRED);
 	}
 

tests/manager/manager-ctor-read_preference-004.phpt

@@ -11,6 +11,7 @@ $tests = [
     ['mongodb://127.0.0.1/?readPreference=nearest', ['slaveok' => true]],
     // False array option is ignored
     ['mongodb://127.0.0.1/?slaveok=true', ['slaveok' => false]],
+    ['mongodb://127.0.0.1/?readPreference=nearest', ['slaveok' => false]],
     // readPreference option takes priority
     ['mongodb://127.0.0.1/?slaveok=true&readPreference=nearest', []],
     ['mongodb://127.0.0.1/?slaveok=false&readPreference=nearest', []],
@@ -86,6 +87,10 @@ object(MongoDB\Driver\ReadPreference)#%d (%d) {
   ["mode"]=>
   string(7) "nearest"
 }
+object(MongoDB\Driver\ReadPreference)#%d (%d) {
+  ["mode"]=>
+  string(7) "nearest"
+}
 object(MongoDB\Driver\ReadPreference)#%d (%d) {
   ["mode"]=>
   string(18) "secondaryPreferred"