PHPC-1629: Check if read preference is valid during unserialization

alcaeus · alcaeus · commit 1bb7240fd76f · 2020-05-29T14:47:24.000+02:00
diff --git a/src/MongoDB/ReadPreference.c b/src/MongoDB/ReadPreference.c
@@ -138,6 +138,11 @@ static bool php_phongo_readpreference_init_from_hash(php_phongo_readpreference_t
 		}
 	}
 
+	if (!mongoc_read_prefs_is_valid(intern->read_preference)) {
+		phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT, "Read preference is not valid");
+		goto failure;
+	}
+
 	return true;
 
 failure:

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,11 @@ static bool php_phongo_readpreference_init_from_hash(php_phongo_readpreference_t`
`138`	`138`	`}`
`139`	`139`	`}`
`140`	`140`
	`141`	`+ if (!mongoc_read_prefs_is_valid(intern->read_preference)) {`
	`142`	`+ phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT, "Read preference is not valid");`
	`143`	`+ goto failure;`
	`144`	`+ }`
	`145`	`+`
`141`	`146`	`return true;`
`142`	`147`
`143`	`148`	`failure:`