PHPC-410: object_to_bson() should throw on unsupported BSON\Type objects

Author: jmikola

src/bson.c

@@ -708,6 +708,9 @@ void object_to_bson(zval *object, php_phongo_bson_flags_t flags, const char *key
 			bson_append_minkey(bson, key, key_len);
 			return;
 		}
+
+		phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE TSRMLS_CC, "Unexpected %s instance: %s", php_phongo_type_ce->name, Z_OBJCE_P(object)->name);
+		return;
 	}
 
 	mongoc_log(MONGOC_LOG_LEVEL_TRACE, MONGOC_LOG_DOMAIN, "encoding document");

tests/bson/bson-fromPHP_error-002.phpt

@@ -0,0 +1,32 @@
+--TEST--o
+BSON\fromPHP(): Encoding unknown Type objects as a document field value
+--SKIPIF--
+<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
+--FILE--
+<?php
+use MongoDB\BSON as BSON;
+
+require_once __DIR__ . "/../utils/basic.inc";
+
+class UnknownType implements BSON\Type {}
+
+$tests = array(
+    array(new UnknownType()),
+    array('x' => new UnknownType()),
+);
+
+foreach ($tests as $document) {
+    echo throws(function() use ($document) {
+        fromPHP($document);
+    }, 'MongoDB\Driver\Exception\UnexpectedValueException'), "\n";
+}
+
+?>
+===DONE===
+<?php exit(0); ?>
+--EXPECTF--
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+Unexpected %SBSON\Type instance: UnknownType
+OK: Got MongoDB\Driver\Exception\UnexpectedValueException
+Unexpected %SBSON\Type instance: UnknownType
+===DONE===