Skip to content

Commit 4d15c14

Browse files
committed
Clean up SKIPIFs for session tests
1 parent fbb2881 commit 4d15c14

9 files changed

+14
-7
lines changed

tests/session/session-003.phpt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ MongoDB\Driver\Session spec test: session cannot be used for different clients
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
55
<?php skip_if_not_libmongoc_crypto(); ?>
66
<?php skip_if_not_live(); ?>
7-
<?php skip_if_not_clean(); ?>
87
<?php skip_if_server_version('<', '3.6'); ?>
98
--FILE--
109
<?php

tests/session/session-endSession-001.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
MongoDB\Driver\Session::endSession() Calling methods after session has been ended
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5+
<?php skip_if_not_libmongoc_crypto(); ?>
56
<?php skip_if_not_replica_set(); ?>
67
<?php skip_if_server_version('<', '4.0'); ?>
78
--FILE--

tests/session/session-startTransaction-001.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ MongoDB\Driver\Session::startTransaction() ensure that methods can be called
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
55
<?php skip_if_not_libmongoc_crypto() ?>
6+
<?php skip_if_not_replica_set(); ?>
67
<?php skip_if_server_version('<', '4.0'); ?>
78
--FILE--
89
<?php

tests/session/session-startTransaction_error-001.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
MongoDB\Driver\Session::startTransaction() twice
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5+
<?php skip_if_not_libmongoc_crypto() ?>
6+
<?php skip_if_not_replica_set(); ?>
57
<?php skip_if_server_version('<', '4.0'); ?>
68
--FILE--
79
<?php

tests/session/session-startTransaction_error-002.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
MongoDB\Driver\Session::startTransaction() with wrong values in options array
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5+
<?php skip_if_not_libmongoc_crypto() ?>
6+
<?php skip_if_not_replica_set(); ?>
57
<?php skip_if_server_version('<', '4.0'); ?>
68
--FILE--
79
<?php

tests/session/session-startTransaction_error-003.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
MongoDB\Driver\Session::startTransaction() with wrong argument for options array
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5+
<?php skip_if_not_libmongoc_crypto() ?>
6+
<?php skip_if_not_replica_set(); ?>
57
<?php skip_if_server_version('<', '4.0'); ?>
68
--FILE--
79
<?php

tests/session/session_error-001.phpt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
--TEST--
22
MongoDB\Driver\Session with wrong defaultTransactionOptions
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
53
--FILE--
64
<?php
75
require_once __DIR__ . "/../utils/basic.inc";
86

9-
$manager = new MongoDB\Driver\Manager(URI);
7+
$manager = new MongoDB\Driver\Manager();
108

119
$options = [
1210
[ 'readConcern' => 42 ],

tests/session/transaction-integration-001.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22
MongoDB\Driver\Session::startTransaction() Committing a transaction with example for how to handle failures
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5-
<?php skip_if_not_clean(DATABASE_NAME, COLLECTION_NAME . '_employees'); ?>
6-
<?php skip_if_not_clean(DATABASE_NAME, COLLECTION_NAME . '_events'); ?>
5+
<?php skip_if_not_libmongoc_crypto(); ?>
76
<?php skip_if_not_replica_set(); ?>
87
<?php skip_if_server_version('<', '4.0'); ?>
8+
<?php skip_if_not_clean(DATABASE_NAME, COLLECTION_NAME . '_employees'); ?>
9+
<?php skip_if_not_clean(DATABASE_NAME, COLLECTION_NAME . '_events'); ?>
910
--FILE--
1011
<?php
1112
require_once __DIR__ . "/../utils/basic.inc";

tests/session/transaction-integration-002.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
MongoDB\Driver\Session::startTransaction() Transient Error Test
33
--SKIPIF--
44
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
5-
<?php skip_if_not_clean(DATABASE_NAME, COLLECTION_NAME); ?>
5+
<?php skip_if_not_libmongoc_crypto(); ?>
66
<?php skip_if_not_replica_set(); ?>
77
<?php skip_if_server_version('<', '4.0'); ?>
8+
<?php skip_if_not_clean(); ?>
89
--FILE--
910
<?php
1011
require_once __DIR__ . "/../utils/basic.inc";

0 commit comments

Comments
 (0)