Skip to content

Commit 5d05759

Browse files
committed
PHPC-519: Add missing modifiers to final class methods
This is just being done for consistency. The classes are all already final (specified in their MINIT function).
1 parent fe3c8c6 commit 5d05759

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

src/BSON/Binary.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,9 @@ ZEND_END_ARG_INFO();
120120

121121

122122
static zend_function_entry php_phongo_binary_me[] = {
123-
PHP_ME(Binary, __construct, ai_Binary___construct, ZEND_ACC_PUBLIC)
124-
PHP_ME(Binary, getData, ai_Binary_getData, ZEND_ACC_PUBLIC)
125-
PHP_ME(Binary, getType, ai_Binary_getType, ZEND_ACC_PUBLIC)
123+
PHP_ME(Binary, __construct, ai_Binary___construct, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
124+
PHP_ME(Binary, getData, ai_Binary_getData, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
125+
PHP_ME(Binary, getType, ai_Binary_getType, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
126126
PHP_ME(Manager, __wakeUp, NULL, ZEND_ACC_PUBLIC)
127127
PHP_FE_END
128128
};

src/BSON/ObjectID.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ ZEND_END_ARG_INFO();
113113

114114

115115
static zend_function_entry php_phongo_objectid_me[] = {
116-
PHP_ME(ObjectID, __construct, ai_ObjectID___construct, ZEND_ACC_PUBLIC)
117-
PHP_ME(ObjectID, __toString, ai_ObjectID___toString, ZEND_ACC_PUBLIC)
116+
PHP_ME(ObjectID, __construct, ai_ObjectID___construct, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
117+
PHP_ME(ObjectID, __toString, ai_ObjectID___toString, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
118118
PHP_ME(Manager, __wakeUp, NULL, ZEND_ACC_PUBLIC)
119119
PHP_FE_END
120120
};

src/BSON/Regex.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ ZEND_END_ARG_INFO();
149149

150150

151151
static zend_function_entry php_phongo_regex_me[] = {
152-
PHP_ME(Regex, __construct, ai_Regex___construct, ZEND_ACC_PUBLIC)
153-
PHP_ME(Regex, getPattern, ai_Regex_getPattern, ZEND_ACC_PUBLIC)
154-
PHP_ME(Regex, getFlags, ai_Regex_getFlags, ZEND_ACC_PUBLIC)
155-
PHP_ME(Regex, __toString, ai_Regex___toString, ZEND_ACC_PUBLIC)
152+
PHP_ME(Regex, __construct, ai_Regex___construct, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
153+
PHP_ME(Regex, getPattern, ai_Regex_getPattern, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
154+
PHP_ME(Regex, getFlags, ai_Regex_getFlags, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
155+
PHP_ME(Regex, __toString, ai_Regex___toString, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
156156
PHP_ME(Manager, __wakeUp, NULL, ZEND_ACC_PUBLIC)
157157
PHP_FE_END
158158
};

src/MongoDB/BulkWrite.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -257,11 +257,11 @@ ZEND_END_ARG_INFO();
257257

258258

259259
static zend_function_entry php_phongo_bulkwrite_me[] = {
260-
PHP_ME(BulkWrite, __construct, ai_BulkWrite___construct, ZEND_ACC_PUBLIC)
261-
PHP_ME(BulkWrite, insert, ai_BulkWrite_insert, ZEND_ACC_PUBLIC)
262-
PHP_ME(BulkWrite, update, ai_BulkWrite_update, ZEND_ACC_PUBLIC)
263-
PHP_ME(BulkWrite, delete, ai_BulkWrite_delete, ZEND_ACC_PUBLIC)
264-
PHP_ME(BulkWrite, count, ai_BulkWrite_count, ZEND_ACC_PUBLIC)
260+
PHP_ME(BulkWrite, __construct, ai_BulkWrite___construct, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
261+
PHP_ME(BulkWrite, insert, ai_BulkWrite_insert, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
262+
PHP_ME(BulkWrite, update, ai_BulkWrite_update, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
263+
PHP_ME(BulkWrite, delete, ai_BulkWrite_delete, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
264+
PHP_ME(BulkWrite, count, ai_BulkWrite_count, ZEND_ACC_PUBLIC|ZEND_ACC_FINAL)
265265
PHP_ME(Manager, __wakeUp, NULL, ZEND_ACC_PUBLIC)
266266
PHP_FE_END
267267
};

0 commit comments

Comments
 (0)