PHPC-1539: Use mongoc error types over generic int

alcaeus · alcaeus · commit 78638e019cd4 · 2020-01-27T19:31:39.000+01:00
diff --git a/php_phongo.c b/php_phongo.c
@@ -136,7 +136,7 @@ zend_class_entry* phongo_exception_from_phongo_domain(php_phongo_error_domain_t
 	MONGOC_ERROR("Resolving unknown phongo error domain: %d", domain);
 	return php_phongo_runtimeexception_ce;
 }
-zend_class_entry* phongo_exception_from_mongoc_domain(uint32_t /* mongoc_error_domain_t */ domain, uint32_t /* mongoc_error_code_t */ code)
+zend_class_entry* phongo_exception_from_mongoc_domain(mongoc_error_domain_t domain, mongoc_error_code_t code)
 {
 	if (domain == MONGOC_ERROR_CLIENT) {
 		if (code == MONGOC_ERROR_CLIENT_AUTHENTICATE) {

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ zend_class_entry* phongo_exception_from_phongo_domain(php_phongo_error_domain_t`
`136`	`136`	`MONGOC_ERROR("Resolving unknown phongo error domain: %d", domain);`
`137`	`137`	`return php_phongo_runtimeexception_ce;`
`138`	`138`	`}`
`139`		`-zend_class_entry* phongo_exception_from_mongoc_domain(uint32_t /* mongoc_error_domain_t / domain, uint32_t / mongoc_error_code_t */ code)`
	`139`	`+zend_class_entry* phongo_exception_from_mongoc_domain(mongoc_error_domain_t domain, mongoc_error_code_t code)`
`140`	`140`	`{`
`141`	`141`	`if (domain == MONGOC_ERROR_CLIENT) {`
`142`	`142`	`if (code == MONGOC_ERROR_CLIENT_AUTHENTICATE) {`