PHPC-1230: Allow cloning Timestamp objects

Author: alcaeus

src/BSON/Timestamp.c

@@ -430,6 +430,32 @@ static phongo_create_object_retval php_phongo_timestamp_create_object(zend_class
 #endif
 } /* }}} */
 
+static phongo_create_object_retval php_phongo_timestamp_clone_object(zval* object TSRMLS_DC) /* {{{ */
+{
+	php_phongo_timestamp_t* intern;
+	php_phongo_timestamp_t* new_intern;
+	phongo_create_object_retval new_object;
+
+	intern = Z_TIMESTAMP_OBJ_P(object);
+	new_object = php_phongo_timestamp_create_object(Z_OBJCE_P(object) TSRMLS_CC);
+
+#if PHP_VERSION_ID >= 70000
+	new_intern = Z_OBJ_TIMESTAMP(new_object);
+	zend_objects_clone_members(&new_intern->std, &intern->std TSRMLS_CC);
+#else
+	{
+		zend_object_handle handle = Z_OBJ_HANDLE_P(object);
+
+		new_intern = (php_phongo_timestamp_t*) zend_object_store_get_object_by_handle(new_object.handle TSRMLS_CC);
+		zend_objects_clone_members(&new_intern->std, new_object, &intern->std, handle TSRMLS_CC);
+	}
+#endif
+
+	php_phongo_timestamp_init(new_intern, intern->increment, intern->timestamp TSRMLS_CC);
+
+	return new_object;
+} /* }}} */
+
 static int php_phongo_timestamp_compare_objects(zval* o1, zval* o2 TSRMLS_DC) /* {{{ */
 {
 	php_phongo_timestamp_t *intern1, *intern2;
@@ -531,6 +557,7 @@ void php_phongo_timestamp_init_ce(INIT_FUNC_ARGS) /* {{{ */
 	zend_class_implements(php_phongo_timestamp_ce TSRMLS_CC, 1, zend_ce_serializable);
 
 	memcpy(&php_phongo_handler_timestamp, phongo_get_std_object_handlers(), sizeof(zend_object_handlers));
+	php_phongo_handler_timestamp.clone_obj       = php_phongo_timestamp_clone_object;
 	php_phongo_handler_timestamp.compare_objects = php_phongo_timestamp_compare_objects;
 	php_phongo_handler_timestamp.get_debug_info  = php_phongo_timestamp_get_debug_info;
 	php_phongo_handler_timestamp.get_gc          = php_phongo_timestamp_get_gc;

tests/bson/bson-timestamp-clone-001.phpt

@@ -0,0 +1,30 @@
+--TEST--
+MongoDB\BSON\Timestamp can be cloned
+--FILE--
+<?php
+
+require_once __DIR__ . '/../utils/tools.php';
+
+$timestamp = new MongoDB\BSON\Timestamp(1234, 5678);
+
+$clone = clone $timestamp;
+
+var_dump($clone == $timestamp);
+var_dump($clone === $timestamp);
+
+unset($timestamp);
+
+var_dump($clone);
+?>
+===DONE===
+<?php exit(0); ?>
+--EXPECTF--
+bool(true)
+bool(false)
+object(MongoDB\BSON\Timestamp)#%d (2) {
+  ["increment"]=>
+  string(4) "1234"
+  ["timestamp"]=>
+  string(4) "5678"
+}
+===DONE===