Skip to content

Commit 85c0317

Browse files
committed
Use correct name for DLL file to fix pie installs
1 parent 8ac30ed commit 85c0317

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

.github/workflows/build-windows-package.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,22 @@ jobs:
112112
with:
113113
filenames: php_mongodb.dll
114114

115-
# Copy the signature file from the release asset directory to avoid directory issues in the ZIP file
116-
- name: "Copy signature file"
117-
run: cp ${RELEASE_ASSETS}/php_mongodb.dll.sig .
115+
- name: "Generate file name for DLL and archive"
116+
run:
117+
echo FILENAME="php_mongodb-${{ inputs.version }}-${{ inputs.php }}-${{ inputs.ts }}-${{ needs.build.outputs.vs }}-${{ inputs.arch == 'x64' && 'x64_86' || inputs.arch }}" >> "$GITHUB_ENV"
118+
119+
# In this step, we:
120+
# - update the extension DLL file name to match the expectation of pie
121+
# - copy the signature file from the release asset directory to avoid directory issues in the archive
122+
# - rename the signature file to match the extension DLL file
123+
- name: "Copy signature file and use correct file names"
124+
run: |
125+
mv php_mongodb.dll ${{ env.FILENAME }}.dll
126+
cp ${RELEASE_ASSETS}/php_mongodb.dll.sig ${{ env.FILENAME }}.dll.sig
118127
119128
- name: "Create and upload release asset"
120129
if: ${{ inputs.upload_release_asset }}
121130
run: |
122-
ARCHIVE=php_mongodb-${{ inputs.version }}-${{ inputs.php }}-${{ inputs.ts }}-${{ needs.build.outputs.vs }}-${{ inputs.arch == 'x64' && 'x64_86' || inputs.arch }}.zip
123-
zip ${ARCHIVE} php_mongodb.dll php_mongodb.dll.sig php_mongodb.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES
131+
ARCHIVE=${{ env.FILENAME }}.zip
132+
zip ${ARCHIVE} ${{ env.FILENAME }}.dll ${{ env.FILENAME }}.dll.sig php_mongodb.pdb CREDITS CONTRIBUTING.md LICENSE README.md THIRD_PARTY_NOTICES
124133
gh release upload ${{ inputs.version }} ${ARCHIVE}

0 commit comments

Comments
 (0)