PHPC-2136: Final modifier should precede method visibility in stub files (#1364)

levon80999 · web-flow · commit 93265d430e46 · 2022-09-16T15:27:35.000+04:00
diff --git a/src/BSON/Binary.stub.php b/src/BSON/Binary.stub.php
@@ -63,7 +63,7 @@ final class Binary implements BinaryInterface, \JsonSerializable, Type, \Seriali
      */
     public const TYPE_USER_DEFINED = UNKNOWN;
 
-    public final function __construct(string $data, int $type = Binary::TYPE_GENERIC) {}
+    final public function __construct(string $data, int $type = Binary::TYPE_GENERIC) {}
 
     final public function getData(): string {}
 
diff --git a/src/BSON/Binary_arginfo.h b/src/BSON/Binary_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 5a6e8f17139479d3183b22dc9e13fd81939b8df9 */
+ * Stub hash: 1ad141cbb9c7c2e49660ba16b36c69de97d7e45e */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Binary___construct, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, data, IS_STRING, 0)
diff --git a/src/BSON/Int64.stub.php b/src/BSON/Int64.stub.php
@@ -9,7 +9,7 @@
 
 final class Int64 implements \JsonSerializable, Type, \Serializable
 {
-    private final function __construct() {}
+    final private function __construct() {}
 
     final public function __toString(): string {}
 
diff --git a/src/BSON/Int64_arginfo.h b/src/BSON/Int64_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 852eeededa19c9411c8fa9b0b364b86759e4819d */
+ * Stub hash: a0fc48411f2ce18661e1e837b79f878f2d80ebd3 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Int64___construct, 0, 0, 0)
 ZEND_END_ARG_INFO()
diff --git a/src/BSON/ObjectId.stub.php b/src/BSON/ObjectId.stub.php
@@ -9,11 +9,11 @@
 
 final class ObjectId implements ObjectIdInterface, \JsonSerializable, Type, \Serializable
 {
-    public final function __construct(?string $id = null) {}
+    final public function __construct(?string $id = null) {}
 
-    public final function getTimestamp(): int {}
+    final public function getTimestamp(): int {}
 
-    public final function __toString(): string {}
+    final public function __toString(): string {}
 
     final public static function __set_state(array $properties): ObjectId {}
 
diff --git a/src/BSON/ObjectId_arginfo.h b/src/BSON/ObjectId_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 542391934fa2e97e850d269b30636bdfc4aa4e65 */
+ * Stub hash: 9cd65d4b38b64b047724d97593fdb6934f6fa896 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_ObjectId___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, id, IS_STRING, 1, "null")
diff --git a/src/BSON/PersistableEnum.stub.php b/src/BSON/PersistableEnum.stub.php
@@ -9,7 +9,7 @@
 
 trait PersistableEnum
 {
-    public final function bsonSerialize(): array {}
+    final public function bsonSerialize(): array {}
 
-    public final function bsonUnserialize(array $data): void {}
+    final public function bsonUnserialize(array $data): void {}
 }
diff --git a/src/BSON/PersistableEnum_arginfo.h b/src/BSON/PersistableEnum_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: db87873800da8dfaf4b3235eed97254593c9b83d */
+ * Stub hash: 948dccc4736ffc466b4a7d3b3e59f1e6cca9a0bb */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_MongoDB_BSON_PersistableEnum_bsonSerialize, 0, 0, IS_ARRAY, 0)
 ZEND_END_ARG_INFO()
diff --git a/src/BSON/Regex.stub.php b/src/BSON/Regex.stub.php
@@ -9,13 +9,13 @@
 
 final class Regex implements RegexInterface, \JsonSerializable, Type, \Serializable
 {
-    public final function __construct(string $pattern, string $flags = '') {}
+    final public function __construct(string $pattern, string $flags = '') {}
 
-    public final function getPattern(): string {}
+    final public function getPattern(): string {}
 
-    public final function getFlags(): string {}
+    final public function getFlags(): string {}
 
-    public final function __toString(): string {}
+    final public function __toString(): string {}
 
     final public static function __set_state(array $properties): Regex {}
 
diff --git a/src/BSON/Regex_arginfo.h b/src/BSON/Regex_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 1896086ecdc06e2f643ec0f158cefc8f2719eff3 */
+ * Stub hash: 7a1ba95f7cc89a83201d46f43ab7e5f2ae93cb5f */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Regex___construct, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, pattern, IS_STRING, 0)
diff --git a/src/BSON/Timestamp.stub.php b/src/BSON/Timestamp.stub.php
@@ -10,20 +10,20 @@
 final class Timestamp implements TimestampInterface, \JsonSerializable, Type, \Serializable
 {
 #if PHP_VERSION_ID >= 80000
-    public final function __construct(int|string $increment, int|string $timestamp) {}
+    final public function __construct(int|string $increment, int|string $timestamp) {}
 #else
     /**
      * @param int|string $increment
      * @param int|string $timestamp
      */
-    public final function __construct($increment, $timestamp) {}
+    final public function __construct($increment, $timestamp) {}
 #endif
 
-    public final function getTimestamp(): int {}
+    final public function getTimestamp(): int {}
 
-    public final function getIncrement(): int {}
+    final public function getIncrement(): int {}
 
-    public final function __toString(): string {}
+    final public function __toString(): string {}
 
     final public static function __set_state(array $properties): Timestamp {}
 
diff --git a/src/BSON/Timestamp_arginfo.h b/src/BSON/Timestamp_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 17b79d50ca648f6aa64d7a5596833b08e4e841b4 */
+ * Stub hash: 2bcdcaf75a5fda393b84df469ca046e7ba720601 */
 
 #if PHP_VERSION_ID >= 80000
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_Timestamp___construct, 0, 0, 2)
diff --git a/src/BSON/UTCDateTime.stub.php b/src/BSON/UTCDateTime.stub.php
@@ -10,15 +10,15 @@
 final class UTCDateTime implements UTCDateTimeInterface, \JsonSerializable, Type, \Serializable
 {
 #if PHP_VERSION_ID >= 80000
-    public final function __construct(int|string|float|\DateTimeInterface|null $milliseconds = null) {}
+    final public function __construct(int|string|float|\DateTimeInterface|null $milliseconds = null) {}
 #else
     /** @param int|string|float|\DateTimeInterface|null $milliseconds */
-    public final function __construct($milliseconds = null) {}
+    final public function __construct($milliseconds = null) {}
 #endif
 
-    public final function toDateTime(): \DateTime {}
+    final public function toDateTime(): \DateTime {}
 
-    public final function __toString(): string {}
+    final public function __toString(): string {}
 
     final public static function __set_state(array $properties): UTCDateTime {}
 
diff --git a/src/BSON/UTCDateTime_arginfo.h b/src/BSON/UTCDateTime_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 05ae6837c7f219cbe713be1b5edc6e35eb932b5c */
+ * Stub hash: 8ba1df46e121e8ce37a671414d00504e06cb89cd */
 
 #if PHP_VERSION_ID >= 80000
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_BSON_UTCDateTime___construct, 0, 0, 0)
diff --git a/src/MongoDB/BulkWrite.stub.php b/src/MongoDB/BulkWrite.stub.php
@@ -9,7 +9,7 @@
 
 final class BulkWrite implements \Countable
 {
-    public final function __construct(?array $options = null) {}
+    final public function __construct(?array $options = null) {}
 
     public function count(): int {}
 
@@ -21,13 +21,13 @@ public function delete($filter, ?array $deleteOptions = null): void {}
 #endif
 
 #if PHP_VERSION_ID >= 80000
-    public final function insert(array|object $document): mixed {}
+    final public function insert(array|object $document): mixed {}
 #else
     /**
      * @param array|object $document
      * @return mixed
      */
-    public final function insert($document) {}
+    final public function insert($document) {}
 #endif
 
 #if PHP_VERSION_ID >= 80000
diff --git a/src/MongoDB/BulkWrite_arginfo.h b/src/MongoDB/BulkWrite_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 179d375c7c122723254e7b19dd97f8ef33caf38c */
+ * Stub hash: 9c3fc38ad4f6c80bf3605de06889de409e74de78 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_BulkWrite___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, options, IS_ARRAY, 1, "null")
diff --git a/src/MongoDB/CursorId.stub.php b/src/MongoDB/CursorId.stub.php
@@ -9,7 +9,7 @@
 
 final class CursorId implements \Serializable
 {
-    private final function __construct() {}
+    final private function __construct() {}
 
     final public static function __set_state(array $properties): CursorId {}
 
diff --git a/src/MongoDB/CursorId_arginfo.h b/src/MongoDB/CursorId_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 4a60dfaa9c42a5c5ea1a1b1b6e318d3e472f134d */
+ * Stub hash: 38869945e39a889c85c1074ab4d3843c51738674 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_MongoDB_Driver_CursorId___construct, 0, 0, 0)
 ZEND_END_ARG_INFO()

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`final class Int64 implements \JsonSerializable, Type, \Serializable`
`11`	`11`	`{`
`12`		`- private final function __construct() {}`
	`12`	`+ final private function __construct() {}`
`13`	`13`
`14`	`14`	`final public function __toString(): string {}`
`15`	`15`