PHPC-1687: Always free reply from commit_transaction

jmikola · alcaeus · commit a2ccc1d16116 · 2020-10-06T13:07:54.000+02:00
diff --git a/src/MongoDB/Session.c b/src/MongoDB/Session.c
@@ -485,8 +485,9 @@ static PHP_METHOD(Session, commitTransaction)
 
 	if (!mongoc_client_session_commit_transaction(intern->client_session, &reply, &error)) {
 		phongo_throw_exception_from_bson_error_t_and_reply(&error, &reply);
-		bson_destroy(&reply);
 	}
+
+	bson_destroy(&reply);
 } /* }}} */
 
 /* {{{ proto void MongoDB\Driver\Session::abortTransaction(void)

Original file line number	Diff line number	Diff line change
`@@ -485,8 +485,9 @@ static PHP_METHOD(Session, commitTransaction)`
`485`	`485`
`486`	`486`	`if (!mongoc_client_session_commit_transaction(intern->client_session, &reply, &error)) {`
`487`	`487`	`phongo_throw_exception_from_bson_error_t_and_reply(&error, &reply);`
`488`		`- bson_destroy(&reply);`
`489`	`488`	`}`
	`489`	`+`
	`490`	`+ bson_destroy(&reply);`
`490`	`491`	`} /* }}} */`
`491`	`492`
`492`	`493`	`/* {{{ proto void MongoDB\Driver\Session::abortTransaction(void)`