Merge branch 'v1.9'

Author: jmikola

.evergreen/compile-unix.sh

@@ -1,5 +1,4 @@
 #!/bin/sh
-set -o xtrace   # Write all commands first to stderr
 set -o errexit  # Exit the script with error if any of the commands fail
 
 # Supported/used environment variables:

.evergreen/compile-windows.sh

@@ -1,6 +1,5 @@
 #!/bin/sh
 set -o igncr    # Ignore CR in this script
-set -o xtrace   # Write all commands first to stderr
 set -o errexit  # Exit the script with error if any of the commands fail
 
 # Supported/used environment variables:

.evergreen/compile.sh

@@ -1,5 +1,4 @@
 #!/bin/sh
-set -o xtrace   # Write all commands first to stderr
 set -o errexit  # Exit the script with error if any of the commands fail
 
 

.evergreen/config.yml

@@ -101,7 +101,6 @@ functions:
 
            PREPARE_SHELL: |
               set -o errexit
-              set -o xtrace
               export DRIVERS_TOOLS="$DRIVERS_TOOLS"
               export MONGO_ORCHESTRATION_HOME="$MONGO_ORCHESTRATION_HOME"
               export PROJECT_ORCHESTRATION_HOME="$PROJECT_ORCHESTRATION_HOME"
@@ -176,7 +175,7 @@ functions:
     - command: shell.exec
       params:
         continue_on_err: true
-        script: "set -o xtrace && rm -rf ${PROJECT_DIRECTORY}"
+        script: "rm -rf ${PROJECT_DIRECTORY}"
     - command: s3.get
       params:
         aws_key: ${aws_key}
@@ -188,7 +187,7 @@ functions:
       params:
         continue_on_err: true
         # EVG-1105: Use s3.get extract_to: ./
-        script: "set -o xtrace && cd .. && rm -rf ${PROJECT_DIRECTORY} && mkdir ${PROJECT_DIRECTORY}/ && tar xf build.tar.gz -C ${PROJECT_DIRECTORY}/"
+        script: "cd .. && rm -rf ${PROJECT_DIRECTORY} && mkdir ${PROJECT_DIRECTORY}/ && tar xf build.tar.gz -C ${PROJECT_DIRECTORY}/"
 
   "exec compile script" :
     - command: shell.exec
@@ -473,7 +472,6 @@ tasks:
           type: test
           params:
             script: |
-               set -o xtrace
                . ${DRIVERS_TOOLS}/.evergreen/download-mongodb.sh || true
                get_distro || true
                echo $DISTRO

.evergreen/run-ocsp-responder.sh

@@ -24,7 +24,6 @@
 
 # Fail on any command returning a non-zero exit status.
 set -o errexit
-set -o xtrace
 
 USE_DELEGATE=${USE_DELEGATE:-OFF}
 

.evergreen/run-tests.sh

@@ -1,5 +1,4 @@
 #!/bin/sh
-set -o xtrace   # Write all commands first to stderr
 set -o errexit  # Exit the script with error if any of the commands fail
 
 # Supported/used environment variables:

src/MongoDB/Manager.c

@@ -816,7 +816,7 @@ ZEND_BEGIN_ARG_INFO_EX(ai_Manager_executeBulkWrite, 0, 0, 2)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(ai_Manager_selectServer, 0, 0, 1)
-	ZEND_ARG_OBJ_INFO(0, readPreference, MongoDB\\Driver\\ReadPreference, 1)
+	ZEND_ARG_OBJ_INFO(0, readPreference, MongoDB\\Driver\\ReadPreference, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(ai_Manager_startSession, 0, 0, 0)