PHPC-2146: Refactor typemap struct and BSON encoding/decoding of zvals (#1369)

alcaeus · web-flow · commit b0b1fd1b944e · 2022-10-24T12:22:18.000+02:00
* Avoid re-parsing bson when converting to zval

A lot of occurrences start out with a bson_t*, then call bson_get_data on it to pass it to php_phongo_bson_to_zval_ex. This however creates a new bson reader and creates a new bson_t* from the given data. This is unnecessary and we should pass the original bson_t* in these instances.

* Refactor typemap struct

* Extract object initialisation from document visitor

* Refactor document and array visitors

* Fix wrong signature in array visitor declaration

* Rename ce member for consistency

* Add exception thrown comment

* Fix clang-format
diff --git a/src/BSON/Javascript.c b/src/BSON/Javascript.c
@@ -94,7 +94,7 @@ HashTable* php_phongo_javascript_get_properties_hash(phongo_compat_object_handle
 			php_phongo_bson_state state;
 
 			PHONGO_BSON_INIT_STATE(state);
-			if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->scope), intern->scope->len, &state)) {
+			if (!php_phongo_bson_to_zval_ex(intern->scope, &state)) {
 				zval_ptr_dtor(&state.zchild);
 				goto failure;
 			}
@@ -194,7 +194,7 @@ static PHP_METHOD(MongoDB_BSON_Javascript, getScope)
 
 		PHONGO_BSON_INIT_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->scope), intern->scope->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(intern->scope, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
@@ -220,7 +220,7 @@ static PHP_METHOD(MongoDB_BSON_Javascript, jsonSerialize)
 		php_phongo_bson_state state;
 
 		PHONGO_BSON_INIT_STATE(state);
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->scope), intern->scope->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(intern->scope, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
@@ -244,7 +244,7 @@ static PHP_METHOD(MongoDB_BSON_Javascript, serialize)
 	PHONGO_PARSE_PARAMETERS_NONE();
 
 	if (intern->scope && intern->scope->len) {
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->scope), intern->scope->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(intern->scope, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
diff --git a/src/BSON/functions.c b/src/BSON/functions.c
@@ -65,7 +65,7 @@ PHP_FUNCTION(toPHP)
 		return;
 	}
 
-	if (!php_phongo_bson_to_zval_ex((const unsigned char*) data, data_len, &state)) {
+	if (!php_phongo_bson_data_to_zval_ex((const unsigned char*) data, data_len, &state)) {
 		zval_ptr_dtor(&state.zchild);
 		php_phongo_bson_typemap_dtor(&state.map);
 		RETURN_NULL();
diff --git a/src/MongoDB/BulkWrite.c b/src/MongoDB/BulkWrite.c
@@ -40,9 +40,9 @@ static void php_phongo_bulkwrite_extract_id(bson_t* doc, zval** return_value)
 	php_phongo_bson_state state;
 
 	PHONGO_BSON_INIT_STATE(state);
-	state.map.root_type = PHONGO_TYPEMAP_NATIVE_ARRAY;
+	state.map.root.type = PHONGO_TYPEMAP_NATIVE_ARRAY;
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(doc), doc->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(doc, &state)) {
 		goto cleanup;
 	}
 
@@ -632,7 +632,7 @@ static HashTable* php_phongo_bulkwrite_get_debug_info(phongo_compat_object_handl
 	if (intern->let) {
 		zval zv;
 
-		if (!php_phongo_bson_to_zval(bson_get_data(intern->let), intern->let->len, &zv)) {
+		if (!php_phongo_bson_to_zval(intern->let, &zv)) {
 			zval_ptr_dtor(&zv);
 			goto done;
 		}
diff --git a/src/MongoDB/ClientEncryption.c b/src/MongoDB/ClientEncryption.c
@@ -40,15 +40,15 @@ static void phongo_clientencryption_create_datakey(php_phongo_clientencryption_t
 static void phongo_clientencryption_encrypt(php_phongo_clientencryption_t* clientencryption, zval* zvalue, zval* zciphertext, zval* options);
 static void phongo_clientencryption_decrypt(php_phongo_clientencryption_t* clientencryption, zval* zciphertext, zval* zvalue);
 
-#define RETVAL_BSON_T(reply)                                                             \
-	do {                                                                                 \
-		php_phongo_bson_state state;                                                     \
-		PHONGO_BSON_INIT_STATE(state);                                                   \
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(&(reply)), (reply).len, &state)) { \
-			zval_ptr_dtor(&state.zchild);                                                \
-			goto cleanup;                                                                \
-		}                                                                                \
-		RETVAL_ZVAL(&state.zchild, 0, 1);                                                \
+#define RETVAL_BSON_T(reply)                                 \
+	do {                                                     \
+		php_phongo_bson_state state;                         \
+		PHONGO_BSON_INIT_STATE(state);                       \
+		if (!php_phongo_bson_to_zval_ex(&(reply), &state)) { \
+			zval_ptr_dtor(&state.zchild);                    \
+			goto cleanup;                                    \
+		}                                                    \
+		RETVAL_ZVAL(&state.zchild, 0, 1);                    \
 	} while (0)
 
 #define RETVAL_OPTIONAL_BSON_T(reply) \
diff --git a/src/MongoDB/Command.c b/src/MongoDB/Command.c
@@ -156,7 +156,7 @@ static HashTable* php_phongo_command_get_debug_info(phongo_compat_object_handler
 	if (intern->bson) {
 		zval zv;
 
-		if (!php_phongo_bson_to_zval(bson_get_data(intern->bson), intern->bson->len, &zv)) {
+		if (!php_phongo_bson_to_zval(intern->bson, &zv)) {
 			zval_ptr_dtor(&zv);
 			goto done;
 		}
diff --git a/src/MongoDB/Cursor.c b/src/MongoDB/Cursor.c
@@ -90,7 +90,7 @@ static PHP_METHOD(MongoDB_Driver_Cursor, setTypeMap)
 	if (restore_current_element && mongoc_cursor_current(intern->cursor)) {
 		const bson_t* doc = mongoc_cursor_current(intern->cursor);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(doc), doc->len, &intern->visitor_data)) {
+		if (!php_phongo_bson_to_zval_ex(doc, &intern->visitor_data)) {
 			php_phongo_cursor_free_current(intern);
 		}
 	}
@@ -223,7 +223,7 @@ static PHP_METHOD(MongoDB_Driver_Cursor, next)
 	}
 
 	if (mongoc_cursor_next(intern->cursor, &doc)) {
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(doc), doc->len, &intern->visitor_data)) {
+		if (!php_phongo_bson_to_zval_ex(doc, &intern->visitor_data)) {
 			/* Free invalid result, but don't return as we want to free the
 			 * session if the intern is exhausted. */
 			php_phongo_cursor_free_current(intern);
@@ -278,7 +278,7 @@ static PHP_METHOD(MongoDB_Driver_Cursor, rewind)
 	doc = mongoc_cursor_current(intern->cursor);
 
 	if (doc) {
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(doc), doc->len, &intern->visitor_data)) {
+		if (!php_phongo_bson_to_zval_ex(doc, &intern->visitor_data)) {
 			/* Free invalid result, but don't return as we want to free the
 			 * session if the intern is exhausted. */
 			php_phongo_cursor_free_current(intern);
diff --git a/src/MongoDB/Monitoring/CommandFailedEvent.c b/src/MongoDB/Monitoring/CommandFailedEvent.c
@@ -94,7 +94,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandFailedEvent, getReply)
 
 	PHONGO_PARSE_PARAMETERS_NONE();
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {
 		zval_ptr_dtor(&state.zchild);
 		return;
 	}
@@ -223,7 +223,7 @@ static HashTable* php_phongo_commandfailedevent_get_debug_info(phongo_compat_obj
 	sprintf(operation_id, "%" PRIu64, intern->operation_id);
 	ADD_ASSOC_STRING(&retval, "operationId", operation_id);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {
 		zval_ptr_dtor(&reply_state.zchild);
 		goto done;
 	}
diff --git a/src/MongoDB/Monitoring/CommandStartedEvent.c b/src/MongoDB/Monitoring/CommandStartedEvent.c
@@ -44,7 +44,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandStartedEvent, getCommand)
 
 	PHONGO_PARSE_PARAMETERS_NONE();
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->command), intern->command->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->command, &state)) {
 		zval_ptr_dtor(&state.zchild);
 		return;
 	}
@@ -202,7 +202,7 @@ static HashTable* php_phongo_commandstartedevent_get_debug_info(phongo_compat_ob
 	*is_temp = 1;
 	array_init_size(&retval, 6);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->command), intern->command->len, &command_state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->command, &command_state)) {
 		zval_ptr_dtor(&command_state.zchild);
 		goto done;
 	}
diff --git a/src/MongoDB/Monitoring/CommandSucceededEvent.c b/src/MongoDB/Monitoring/CommandSucceededEvent.c
@@ -82,7 +82,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandSucceededEvent, getReply)
 
 	PHONGO_PARSE_PARAMETERS_NONE();
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {
 		zval_ptr_dtor(&state.zchild);
 		return;
 	}
@@ -204,7 +204,7 @@ static HashTable* php_phongo_commandsucceededevent_get_debug_info(phongo_compat_
 	sprintf(operation_id, "%" PRIu64, intern->operation_id);
 	ADD_ASSOC_STRING(&retval, "operationId", operation_id);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {
 		zval_ptr_dtor(&reply_state.zchild);
 		goto done;
 	}
diff --git a/src/MongoDB/Monitoring/ServerHeartbeatSucceededEvent.c b/src/MongoDB/Monitoring/ServerHeartbeatSucceededEvent.c
@@ -66,7 +66,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_ServerHeartbeatSucceededEvent, getRe
 
 	PHONGO_PARSE_PARAMETERS_NONE();
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {
 		zval_ptr_dtor(&state.zchild);
 		return;
 	}
@@ -126,7 +126,7 @@ static HashTable* php_phongo_serverheartbeatsucceededevent_get_debug_info(phongo
 	ADD_ASSOC_LONG_EX(&retval, "port", intern->host.port);
 	ADD_ASSOC_BOOL_EX(&retval, "awaited", intern->awaited);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {
+	if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {
 		zval_ptr_dtor(&reply_state.zchild);
 		goto done;
 	}
diff --git a/src/MongoDB/Query.c b/src/MongoDB/Query.c
@@ -471,7 +471,7 @@ static HashTable* php_phongo_query_get_debug_info(phongo_compat_object_handler_t
 	if (intern->filter) {
 		zval zv;
 
-		if (!php_phongo_bson_to_zval(bson_get_data(intern->filter), intern->filter->len, &zv)) {
+		if (!php_phongo_bson_to_zval(intern->filter, &zv)) {
 			zval_ptr_dtor(&zv);
 			goto done;
 		}
@@ -484,7 +484,7 @@ static HashTable* php_phongo_query_get_debug_info(phongo_compat_object_handler_t
 	if (intern->opts) {
 		zval zv;
 
-		if (!php_phongo_bson_to_zval(bson_get_data(intern->opts), intern->opts->len, &zv)) {
+		if (!php_phongo_bson_to_zval(intern->opts, &zv)) {
 			zval_ptr_dtor(&zv);
 			goto done;
 		}
diff --git a/src/MongoDB/ReadPreference.c b/src/MongoDB/ReadPreference.c
@@ -341,7 +341,7 @@ static PHP_METHOD(MongoDB_Driver_ReadPreference, getHedge)
 
 		PHONGO_BSON_INIT_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(hedge), hedge->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(hedge, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
@@ -412,7 +412,7 @@ static PHP_METHOD(MongoDB_Driver_ReadPreference, getTagSets)
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(tags), tags->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(tags, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
@@ -458,9 +458,9 @@ static HashTable* php_phongo_readpreference_get_properties_hash(phongo_compat_ob
 		/* Use PHONGO_TYPEMAP_NATIVE_ARRAY for the root type since tags is an
 		 * array; however, inner documents and arrays can use the default. */
 		PHONGO_BSON_INIT_STATE(state);
-		state.map.root_type = PHONGO_TYPEMAP_NATIVE_ARRAY;
+		state.map.root.type = PHONGO_TYPEMAP_NATIVE_ARRAY;
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(tags), tags->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(tags, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			goto done;
 		}
@@ -483,7 +483,7 @@ static HashTable* php_phongo_readpreference_get_properties_hash(phongo_compat_ob
 
 		PHONGO_BSON_INIT_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(hedge), hedge->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(hedge, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			goto done;
 		}
@@ -540,7 +540,7 @@ static PHP_METHOD(MongoDB_Driver_ReadPreference, serialize)
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(tags), tags->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(tags, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
@@ -557,7 +557,7 @@ static PHP_METHOD(MongoDB_Driver_ReadPreference, serialize)
 
 		PHONGO_BSON_INIT_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(hedge), hedge->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(hedge, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			return;
 		}
diff --git a/src/MongoDB/Server.c b/src/MongoDB/Server.c
@@ -257,7 +257,7 @@ static PHP_METHOD(MongoDB_Driver_Server, getTags)
 			PHONGO_BSON_INIT_DEBUG_STATE(state);
 			bson_iter_document(&iter, &len, &bytes);
 
-			if (!php_phongo_bson_to_zval_ex(bytes, len, &state)) {
+			if (!php_phongo_bson_data_to_zval_ex(bytes, len, &state)) {
 				/* Exception should already have been thrown */
 				zval_ptr_dtor(&state.zchild);
 				mongoc_server_description_destroy(sd);
@@ -316,7 +316,7 @@ static PHP_METHOD(MongoDB_Driver_Server, getInfo)
 
 	PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(hello_response), hello_response->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(hello_response, &state)) {
 		/* Exception should already have been thrown */
 		zval_ptr_dtor(&state.zchild);
 		goto cleanup;
@@ -640,7 +640,7 @@ bool php_phongo_server_to_zval(zval* retval, mongoc_client_t* client, mongoc_ser
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 		bson_iter_document(&iter, &len, &bytes);
-		if (!php_phongo_bson_to_zval_ex(bytes, len, &state)) {
+		if (!php_phongo_bson_data_to_zval_ex(bytes, len, &state)) {
 			/* Exception already thrown */
 			zval_ptr_dtor(&state.zchild);
 			return false;
@@ -666,7 +666,7 @@ bool php_phongo_server_to_zval(zval* retval, mongoc_client_t* client, mongoc_ser
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 		handshake_response = mongoc_server_description_hello_response(handshake_sd);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(handshake_response), handshake_response->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(handshake_response, &state)) {
 			/* Exception already thrown */
 			mongoc_server_description_destroy(handshake_sd);
 			zval_ptr_dtor(&state.zchild);
@@ -680,7 +680,7 @@ bool php_phongo_server_to_zval(zval* retval, mongoc_client_t* client, mongoc_ser
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(hello_response), hello_response->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(hello_response, &state)) {
 			/* Exception already thrown */
 			zval_ptr_dtor(&state.zchild);
 			return false;
diff --git a/src/MongoDB/ServerDescription.c b/src/MongoDB/ServerDescription.c
@@ -67,7 +67,7 @@ static PHP_METHOD(MongoDB_Driver_ServerDescription, getHelloResponse)
 
 	PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(helloResponse), helloResponse->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(helloResponse, &state)) {
 		/* Exception should already have been thrown */
 		zval_ptr_dtor(&state.zchild);
 		return;
@@ -214,7 +214,7 @@ HashTable* php_phongo_serverdescription_get_properties_hash(phongo_compat_object
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(hello_response), hello_response->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(hello_response, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			goto done;
 		}
diff --git a/src/MongoDB/Session.c b/src/MongoDB/Session.c
@@ -226,7 +226,7 @@ static PHP_METHOD(MongoDB_Driver_Session, getClusterTime)
 		RETURN_NULL();
 	}
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(cluster_time), cluster_time->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(cluster_time, &state)) {
 		/* Exception should already have been thrown */
 		zval_ptr_dtor(&state.zchild);
 		return;
@@ -251,7 +251,7 @@ static PHP_METHOD(MongoDB_Driver_Session, getLogicalSessionId)
 
 	lsid = mongoc_client_session_get_lsid(intern->client_session);
 
-	if (!php_phongo_bson_to_zval_ex(bson_get_data(lsid), lsid->len, &state)) {
+	if (!php_phongo_bson_to_zval_ex(lsid, &state)) {
 		/* Exception should already have been thrown */
 		zval_ptr_dtor(&state.zchild);
 		return;
@@ -602,7 +602,7 @@ static HashTable* php_phongo_session_get_debug_info(phongo_compat_object_handler
 
 		PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-		if (!php_phongo_bson_to_zval_ex(bson_get_data(lsid), lsid->len, &state)) {
+		if (!php_phongo_bson_to_zval_ex(lsid, &state)) {
 			zval_ptr_dtor(&state.zchild);
 			goto done;
 		}
@@ -618,7 +618,7 @@ static HashTable* php_phongo_session_get_debug_info(phongo_compat_object_handler
 
 			PHONGO_BSON_INIT_DEBUG_STATE(state);
 
-			if (!php_phongo_bson_to_zval_ex(bson_get_data(cluster_time), cluster_time->len, &state)) {
+			if (!php_phongo_bson_to_zval_ex(cluster_time, &state)) {
 				zval_ptr_dtor(&state.zchild);
 				goto done;
 			}
diff --git a/src/MongoDB/WriteConcernError.c b/src/MongoDB/WriteConcernError.c
@@ -158,7 +158,7 @@ zend_bool phongo_writeconcernerror_init(zval* return_value, bson_t* bson)
 
 		bson_iter_document(&iter, &len, &data);
 
-		if (!php_phongo_bson_to_zval(data, len, &intern->info)) {
+		if (!php_phongo_bson_data_to_zval(data, len, &intern->info)) {
 			zval_ptr_dtor(&intern->info);
 			ZVAL_UNDEF(&intern->info);
 
diff --git a/src/MongoDB/WriteError.c b/src/MongoDB/WriteError.c
@@ -173,7 +173,7 @@ zend_bool phongo_writeerror_init(zval* return_value, bson_t* bson)
 
 		bson_iter_document(&iter, &len, &data);
 
-		if (!php_phongo_bson_to_zval(data, len, &intern->info)) {
+		if (!php_phongo_bson_data_to_zval(data, len, &intern->info)) {
 			zval_ptr_dtor(&intern->info);
 			ZVAL_UNDEF(&intern->info);
 
diff --git a/src/MongoDB/WriteResult.c b/src/MongoDB/WriteResult.c
diff --git a/src/phongo_bson.c b/src/phongo_bson.c
diff --git a/src/phongo_bson.h b/src/phongo_bson.h
diff --git a/src/phongo_error.c b/src/phongo_error.c

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ PHP_FUNCTION(toPHP)`
`65`	`65`	`return;`
`66`	`66`	`}`
`67`	`67`
`68`		`- if (!php_phongo_bson_to_zval_ex((const unsigned char*) data, data_len, &state)) {`
	`68`	`+ if (!php_phongo_bson_data_to_zval_ex((const unsigned char*) data, data_len, &state)) {`
`69`	`69`	`zval_ptr_dtor(&state.zchild);`
`70`	`70`	`php_phongo_bson_typemap_dtor(&state.map);`
`71`	`71`	`RETURN_NULL();`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ static HashTable* php_phongo_command_get_debug_info(phongo_compat_object_handler`
`156`	`156`	`if (intern->bson) {`
`157`	`157`	`zval zv;`
`158`	`158`
`159`		`- if (!php_phongo_bson_to_zval(bson_get_data(intern->bson), intern->bson->len, &zv)) {`
	`159`	`+ if (!php_phongo_bson_to_zval(intern->bson, &zv)) {`
`160`	`160`	`zval_ptr_dtor(&zv);`
`161`	`161`	`goto done;`
`162`	`162`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandFailedEvent, getReply)`
`94`	`94`
`95`	`95`	`PHONGO_PARSE_PARAMETERS_NONE();`
`96`	`96`
`97`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {`
	`97`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {`
`98`	`98`	`zval_ptr_dtor(&state.zchild);`
`99`	`99`	`return;`
`100`	`100`	`}`
`@@ -223,7 +223,7 @@ static HashTable* php_phongo_commandfailedevent_get_debug_info(phongo_compat_obj`
`223`	`223`	`sprintf(operation_id, "%" PRIu64, intern->operation_id);`
`224`	`224`	`ADD_ASSOC_STRING(&retval, "operationId", operation_id);`
`225`	`225`
`226`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {`
	`226`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {`
`227`	`227`	`zval_ptr_dtor(&reply_state.zchild);`
`228`	`228`	`goto done;`
`229`	`229`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandStartedEvent, getCommand)`
`44`	`44`
`45`	`45`	`PHONGO_PARSE_PARAMETERS_NONE();`
`46`	`46`
`47`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->command), intern->command->len, &state)) {`
	`47`	`+ if (!php_phongo_bson_to_zval_ex(intern->command, &state)) {`
`48`	`48`	`zval_ptr_dtor(&state.zchild);`
`49`	`49`	`return;`
`50`	`50`	`}`
`@@ -202,7 +202,7 @@ static HashTable* php_phongo_commandstartedevent_get_debug_info(phongo_compat_ob`
`202`	`202`	`*is_temp = 1;`
`203`	`203`	`array_init_size(&retval, 6);`
`204`	`204`
`205`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->command), intern->command->len, &command_state)) {`
	`205`	`+ if (!php_phongo_bson_to_zval_ex(intern->command, &command_state)) {`
`206`	`206`	`zval_ptr_dtor(&command_state.zchild);`
`207`	`207`	`goto done;`
`208`	`208`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_CommandSucceededEvent, getReply)`
`82`	`82`
`83`	`83`	`PHONGO_PARSE_PARAMETERS_NONE();`
`84`	`84`
`85`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {`
	`85`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {`
`86`	`86`	`zval_ptr_dtor(&state.zchild);`
`87`	`87`	`return;`
`88`	`88`	`}`
`@@ -204,7 +204,7 @@ static HashTable* php_phongo_commandsucceededevent_get_debug_info(phongo_compat_`
`204`	`204`	`sprintf(operation_id, "%" PRIu64, intern->operation_id);`
`205`	`205`	`ADD_ASSOC_STRING(&retval, "operationId", operation_id);`
`206`	`206`
`207`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {`
	`207`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {`
`208`	`208`	`zval_ptr_dtor(&reply_state.zchild);`
`209`	`209`	`goto done;`
`210`	`210`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ static PHP_METHOD(MongoDB_Driver_Monitoring_ServerHeartbeatSucceededEvent, getRe`
`66`	`66`
`67`	`67`	`PHONGO_PARSE_PARAMETERS_NONE();`
`68`	`68`
`69`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &state)) {`
	`69`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &state)) {`
`70`	`70`	`zval_ptr_dtor(&state.zchild);`
`71`	`71`	`return;`
`72`	`72`	`}`
`@@ -126,7 +126,7 @@ static HashTable* php_phongo_serverheartbeatsucceededevent_get_debug_info(phongo`
`126`	`126`	`ADD_ASSOC_LONG_EX(&retval, "port", intern->host.port);`
`127`	`127`	`ADD_ASSOC_BOOL_EX(&retval, "awaited", intern->awaited);`
`128`	`128`
`129`		`- if (!php_phongo_bson_to_zval_ex(bson_get_data(intern->reply), intern->reply->len, &reply_state)) {`
	`129`	`+ if (!php_phongo_bson_to_zval_ex(intern->reply, &reply_state)) {`
`130`	`130`	`zval_ptr_dtor(&reply_state.zchild);`
`131`	`131`	`goto done;`
`132`	`132`	`}`