PHPC-1110: Jump on uninitialised variable causes advanceOperationTime test failure

derickr · derickr · commit c6bbbc3fd78e · 2018-07-27T11:45:52.000+01:00
diff --git a/src/MongoDB/Session.c b/src/MongoDB/Session.c
@@ -39,8 +39,8 @@ static bool php_phongo_session_get_timestamp_parts(zval* obj, uint32_t* timestam
 {
 	bool retval = false;
 #if PHP_VERSION_ID >= 70000
-	zval ztimestamp;
-	zval zincrement;
+	zval ztimestamp = ZVAL_STATIC_INIT;
+	zval zincrement = ZVAL_STATIC_INIT;
 
 	zend_call_method_with_0_params(obj, NULL, NULL, "getTimestamp", &ztimestamp);
 

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ static bool php_phongo_session_get_timestamp_parts(zval* obj, uint32_t* timestam`
`39`	`39`	`{`
`40`	`40`	`bool retval = false;`
`41`	`41`	`#if PHP_VERSION_ID >= 70000`
`42`		`- zval ztimestamp;`
`43`		`- zval zincrement;`
	`42`	`+ zval ztimestamp = ZVAL_STATIC_INIT;`
	`43`	`+ zval zincrement = ZVAL_STATIC_INIT;`
`44`	`44`
`45`	`45`	`zend_call_method_with_0_params(obj, NULL, NULL, "getTimestamp", &ztimestamp);`
`46`	`46`