Skip to content

Commit d6ceb3b

Browse files
committed
PHPC-128: Fix running tests on travis
We no longer require Mongo Orchestration now. You can export MONGODB_STANDALONE_URI environment variable with dsn to connect to.
1 parent 5309c17 commit d6ceb3b

File tree

2 files changed

+41
-18
lines changed

2 files changed

+41
-18
lines changed

tests/utils/basic-skipif.inc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@ if ( ! extension_loaded("phongo")) {
44
exit("skip phongo not loaded");
55
}
66

7-
require_once __DIR__ . "/basic.inc";
7+
require __DIR__ . "/" . "basic.inc";
8+
$testdir = basename(dirname(realpath($_SERVER["SCRIPT_FILENAME"])));
9+
10+
switch($testdir){
11+
case "connect":
12+
if (!$orch->ping()) {
13+
exit("skip these tests in $testdir require Mongo Orchestration");
14+
}
15+
break;
16+
}
817

918
CLEANUP();

tests/utils/basic.inc

Lines changed: 31 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,43 @@ require __DIR__ . "/" . "orchestration.php";
33
require __DIR__ . "/" . "tools.php";
44

55

6-
$host = "http://192.168.112.10:8889";
7-
if ($_ENV && isset($_ENV["ORCHESTRATION"])) {
8-
$host = $_ENV["ORCHESTRATION"];
6+
if (!($host = getenv("MONGODB_ORCHESTRATION"))) {
7+
$host = "http://192.168.112.10:8889";
98
}
109

11-
1210
$orch = new Mongo\Orchestration($host);
13-
if (!$orch->ping()) {
14-
exit("skip Mongo Orchestration not running on {$host} - run 'make test-bootstrap'");
11+
if ($orch->ping()) {
12+
$consts = array(
13+
"MONGODB_URI" => $orch->getURI("standalone.json"),
14+
"MONGODB_CLEANUP_URI" => $orch->getURI("standalone.json"),
15+
"MONGODB_STANDALONE_URI" => $orch->getURI("standalone.json"),
16+
"MONGODB_STANDALONE_AUTH_URI" => $orch->getURI("standalone-auth.json"),
17+
"MONGODB_STANDALONE_SSL_URI" => $orch->getURI("standalone-ssl.json"),
18+
"MONGODB_STANDALONE_PLAIN_URI" => $orch->getURI("standalone-plain.json"),
19+
"MONGODB_STANDALONE_X509_URI" => $orch->getURI("standalone-x509.json"),
20+
"MONGODB_REPLICASET_URI" => $orch->getURI("replicaset.json"),
21+
);
22+
} else {
23+
$consts = array(
24+
"MONGODB_URI" => getenv("MONGODB_TEST_URI"),
25+
"MONGODB_CLEANUP_URI" => getenv("MONGODB_TEST_URI"),
26+
"MONGODB_STANDALONE_URI" => getenv("MONGODB_STANDALONE_URI"),
27+
"MONGODB_STANDALONE_AUTH_URI" => getenv("MONGODB_STANDALONE_AUTH_URI"),
28+
"MONGODB_STANDALONE_SSL_URI" => getenv("MONGODB_STANDALONE_SSL_URI"),
29+
"MONGODB_STANDALONE_PLAIN_URI" => getenv("MONGODB_STANDALONE_PLAIN_URI"),
30+
"MONGODB_STANDALONE_X509_URI" => getenv("MONGODB_STANDALONE_X509_URI"),
31+
"MONGODB_REPLICASET_URI" => getenv("MONGODB_REPLICASET_URI"),
32+
);
33+
1534
}
35+
def($consts);
36+
37+
1638

1739
$consts = array(
18-
"MONGODB_URI" => $orch->getURI("standalone.json"),
19-
"MONGODB_CLEANUP_URI" => $orch->getURI("standalone.json"),
20-
"MONGODB_STANDALONE_URI" => $orch->getURI("standalone.json"),
21-
"MONGODB_STANDALONE_AUTH_URI" => $orch->getURI("standalone-auth.json"),
22-
"MONGODB_STANDALONE_SSL_URI" => $orch->getURI("standalone-ssl.json"),
23-
"MONGODB_STANDALONE_PLAIN_URI" => $orch->getURI("standalone-plain.json"),
24-
"MONGODB_STANDALONE_X509_URI" => $orch->getURI("standalone-x509.json"),
25-
"MONGODB_REPLICASET_URI" => $orch->getURI("replicaset.json"),
26-
"DATABASE_NAME" => "phongo",
27-
"COLLECTION_NAME" => makeCollectionNameFromFilename($_SERVER["SCRIPT_FILENAME"]),
28-
"DEBUG_DIR" => sys_get_temp_dir() . "/PHONGO-TESTS/",
40+
"DATABASE_NAME" => "phongo",
41+
"COLLECTION_NAME" => makeCollectionNameFromFilename($_SERVER["SCRIPT_FILENAME"]),
42+
"DEBUG_DIR" => sys_get_temp_dir() . "/PHONGO-TESTS/",
2943
);
3044
def($consts);
3145

0 commit comments

Comments
 (0)