Update tests and psalm baseline

Author: GromNaN

psalm-baseline.xml

@@ -470,6 +470,10 @@
       <code><![CDATA[$args[0]]]></code>
       <code><![CDATA[$args[0]]]></code>
       <code><![CDATA[$args[0]]]></code>
+      <code><![CDATA[$args[0]]]></code>
+      <code><![CDATA[$args[0]]]></code>
+      <code><![CDATA[$args[1]]]></code>
+      <code><![CDATA[$args[1]]]></code>
       <code><![CDATA[$args[1]]]></code>
       <code><![CDATA[$args[1]]]></code>
       <code><![CDATA[$args[1]]]></code>
@@ -726,9 +730,6 @@
     <MixedAssignment>
       <code><![CDATA[$options['fields']]]></code>
     </MixedAssignment>
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$replacement]]></code>
-    </PossiblyInvalidArgument>
   </file>
   <file src="src/Operation/FindOneAndUpdate.php">
     <MixedAssignment>
@@ -745,9 +746,6 @@
     <MixedMethodCall>
       <code><![CDATA[isInTransaction]]></code>
     </MixedMethodCall>
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$document]]></code>
-    </PossiblyInvalidArgument>
   </file>
   <file src="src/Operation/InsertOne.php">
     <MixedAssignment>
@@ -759,9 +757,6 @@
     <MixedMethodCall>
       <code><![CDATA[isInTransaction]]></code>
     </MixedMethodCall>
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$document]]></code>
-    </PossiblyInvalidArgument>
   </file>
   <file src="src/Operation/ListIndexes.php">
     <MixedAssignment>
@@ -789,11 +784,6 @@
       <code><![CDATA[isInTransaction]]></code>
     </MixedMethodCall>
   </file>
-  <file src="src/Operation/ReplaceOne.php">
-    <PossiblyInvalidArgument>
-      <code><![CDATA[$replacement]]></code>
-    </PossiblyInvalidArgument>
-  </file>
   <file src="src/Operation/Update.php">
     <MixedArgument>
       <code><![CDATA[$this->options['writeConcern']]]></code>

src/Operation/FindOneAndReplace.php

@@ -172,7 +172,7 @@ public function getCommandDocument(): array
 
     private function validateReplacement(array|object $replacement, ?DocumentCodec $codec): array|object
     {
-        if ($codec && is_object($replacement)) {
+        if ($codec) {
             if (! is_object($replacement)) {
                 throw UnsupportedValueException::invalidEncodableValue($replacement);
             }

tests/Collection/CodecCollectionFunctionalTest.php

@@ -8,6 +8,7 @@
 use MongoDB\Collection;
 use MongoDB\Driver\BulkWrite;
 use MongoDB\Exception\InvalidArgumentException;
+use MongoDB\Exception\UnsupportedValueException;
 use MongoDB\Model\BSONDocument;
 use MongoDB\Operation\FindOneAndReplace;
 use MongoDB\Tests\Fixtures\Codec\TestDocumentCodec;
@@ -264,6 +265,12 @@ public function testFindOneAndReplaceWithCodecAndTypemap(): void
         $this->collection->findOneAndReplace(['_id' => 1], TestObject::createForFixture(1), $options);
     }
 
+    public function testFindOneAndReplaceWithArray(): void
+    {
+        $this->expectExceptionObject(UnsupportedValueException::invalidEncodableValue([]));
+        $this->collection->findOneAndReplace(['_id' => 1], ['foo' => 'bar']);
+    }
+
     public static function provideFindOptions(): Generator
     {
         yield 'Default codec' => [
@@ -413,6 +420,12 @@ public function testInsertMany($expected, $options): void
         $this->assertEquals($expected, $this->collection->find([], $options)->toArray());
     }
 
+    public function testInsertManyWithArray(): void
+    {
+        $this->expectExceptionObject(UnsupportedValueException::invalidEncodableValue([]));
+        $this->collection->insertMany([['foo' => 'bar']]);
+    }
+
     public static function provideInsertOneOptions(): Generator
     {
         yield 'Default codec' => [
@@ -452,6 +465,12 @@ public function testInsertOne($expected, $options): void
         $this->assertEquals($expected, $this->collection->findOne([], $options));
     }
 
+    public function testInsertOneWithArray(): void
+    {
+        $this->expectExceptionObject(UnsupportedValueException::invalidEncodableValue([]));
+        $this->collection->insertOne(['foo' => 'bar']);
+    }
+
     public static function provideReplaceOneOptions(): Generator
     {
         $replacedObject = TestObject::createDecodedForFixture(1);
@@ -499,7 +518,13 @@ public function testReplaceOneWithCodecAndTypemap(): void
         ];
 
         $this->expectExceptionObject(InvalidArgumentException::cannotCombineCodecAndTypeMap());
-        $this->collection->replaceOne(['_id' => 1], ['foo' => 'bar'], $options);
+        $this->collection->replaceOne(['_id' => 1], (object) ['foo' => 'bar'], $options);
+    }
+
+    public function testReplaceOneWithArray(): void
+    {
+        $this->expectExceptionObject(UnsupportedValueException::invalidEncodableValue([]));
+        $this->collection->replaceOne(['_id' => 1], ['foo' => 'bar']);
     }
 
     /**