Resolve StreamWrapper todo items for read/write differences

WritableStreams cannot be read and are never EOF. ReadableStreams cannot be written.

Author: jmikola

src/GridFS/StreamWrapper.php

@@ -57,6 +57,10 @@ public function stream_close()
      */
     public function stream_eof()
     {
+        if ( ! $this->stream instanceof ReadableStream) {
+            return false;
+        }
+
         return $this->stream->isEOF();
     }
 
@@ -93,11 +97,14 @@ public function stream_open($path, $mode, $options, &$openedPath)
      * 
      * @see http://php.net/manual/en/streamwrapper.stream-read.php
      * @param integer $count Number of bytes to read
-     * @return string 
+     * @return string
      */
     public function stream_read($count)
     {
-        // TODO: Ensure that $this->stream is a ReadableStream
+        if ( ! $this->stream instanceof ReadableStream) {
+            return '';
+        }
+
         return $this->stream->downloadNumBytes($count);
     }
 
@@ -122,13 +129,15 @@ public function stream_stat()
      *
      * @see http://php.net/manual/en/streamwrapper.stream-write.php
      * @param string $data Data to write
-     * @return integer The number of bytes successfully stored
+     * @return integer The number of bytes written
      */
     public function stream_write($data)
     {
-        // TODO: Ensure that $this->stream is a WritableStream
-        $this->stream->insertChunks($data);
+        if ( ! $this->stream instanceof WritableStream) {
+            return 0;
+        }
 
+        $this->stream->insertChunks($data);
         return strlen($data);
     }
 

src/GridFS/WritableStream.php

@@ -184,11 +184,6 @@ public function insertChunks($toWrite)
         return $readBytes;
     }
 
-    public function isEOF()
-    {
-        return $this->isClosed;
-    }
-
     private function abort()
     {
         $this->collectionWrapper->deleteChunksByFilesId($this->file['_id']);