Improve static analysis results

Author: GromNaN

psalm-baseline.xml

@@ -63,6 +63,8 @@
     <MixedAssignment>
       <code><![CDATA[$result]]></code>
       <code><![CDATA[$result[]]]></code>
+      <code><![CDATA[$subval]]></code>
+      <code><![CDATA[$val]]></code>
       <code><![CDATA[$val]]></code>
       <code><![CDATA[$val]]></code>
       <code><![CDATA[$val]]></code>
@@ -168,6 +170,11 @@
       <code><![CDATA[stdClass]]></code>
     </TooManyTemplateParams>
   </file>
+  <file src="src/Builder/Stage/VectorSearchStage.php">
+    <MixedArgumentTypeCoercion>
+      <code><![CDATA[$filter]]></code>
+    </MixedArgumentTypeCoercion>
+  </file>
   <file src="src/Builder/Type/QueryObject.php">
     <MixedAssignment>
       <code><![CDATA[$queries[$fieldPath]]]></code>

src/Builder/Encoder/OperatorEncoder.php

@@ -115,47 +115,49 @@ private function encodeAsGroup(OperatorInterface $value): stdClass
         return $this->wrap($value, $result);
     }
 
-    private function encodeAsSearch(OperatorInterface $value): stdClass
+    private function encodeAsObject(OperatorInterface $value): stdClass
     {
-        assert($value instanceof SearchStage || $value instanceof SearchMetaStage);
-
         $result = new stdClass();
         foreach (get_object_vars($value) as $key => $val) {
             // Skip optional arguments. If they have a default value, it is resolved by the server.
             if ($val === Optional::Undefined) {
                 continue;
             }
 
-            // Merge the operator properties into the result object
-            if ($key === 'operator') {
-                foreach (get_object_vars($this->recursiveEncode($val)) as $subkey => $subval) {
-                    $result->{$subkey} = $subval;
-                }
-
-                continue;
-            }
-
             $result->{$key} = $this->recursiveEncode($val);
         }
 
-        return $this->wrap($value, $result);
+        return $value::ENCODE === Encode::FlatObject
+            ? $result
+            : $this->wrap($value, $result);
     }
 
-    private function encodeAsObject(OperatorInterface $value): stdClass
+    private function encodeAsSearch(OperatorInterface $value): stdClass
     {
+        assert($value instanceof SearchStage || $value instanceof SearchMetaStage);
+
         $result = new stdClass();
         foreach (get_object_vars($value) as $key => $val) {
             // Skip optional arguments. If they have a default value, it is resolved by the server.
             if ($val === Optional::Undefined) {
                 continue;
             }
 
+            // Merge the operator properties into the result object
+            if ($key === 'operator') {
+                $val = $this->recursiveEncode($val);
+                assert($val instanceof stdClass);
+                foreach (get_object_vars($val) as $subkey => $subval) {
+                    $result->{$subkey} = $subval;
+                }
+
+                continue;
+            }
+
             $result->{$key} = $this->recursiveEncode($val);
         }
 
-        return $value::ENCODE === Encode::FlatObject
-            ? $result
-            : $this->wrap($value, $result);
+        return $this->wrap($value, $result);
     }
 
     /**