PHPLIB-360: Make ChangeStream::CURSOR_NOT_FOUND private

alcaeus · alcaeus · commit 7dfc04364637 · 2024-09-23T14:14:00.000+02:00
diff --git a/UPGRADE-2.0.md b/UPGRADE-2.0.md
@@ -2,6 +2,7 @@ UPGRADE FROM 1.x to 2.0
 ========================
 
  * Classes in the namespace `MongoDB\Operation\` are `final`.
+ * The `MongoDB\ChangeStream::CURSOR_NOT_FOUND` constant is now private.
 
 GridFS
 ------
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -181,9 +181,6 @@
     </RedundantConditionGivenDocblockType>
   </file>
   <file src="src/ChangeStream.php">
-    <DeprecatedConstant>
-      <code><![CDATA[self::CURSOR_NOT_FOUND]]></code>
-    </DeprecatedConstant>
     <TooManyArguments>
       <code><![CDATA[getId]]></code>
     </TooManyArguments>
diff --git a/src/ChangeStream.php b/src/ChangeStream.php
@@ -49,11 +49,7 @@
  */
 class ChangeStream implements Iterator
 {
-    /**
-     * @deprecated 1.4
-     * @todo make this constant private in 2.0 (see: PHPLIB-360)
-     */
-    public const CURSOR_NOT_FOUND = 43;
+    private const CURSOR_NOT_FOUND = 43;
 
     private const RESUMABLE_ERROR_CODES = [
         6, // HostUnreachable
