Throw an UnsupportedValueException instead of skipping the codec for array input

Author: GromNaN

src/Operation/BulkWrite.php

@@ -28,6 +28,7 @@
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
+use MongoDB\Exception\UnsupportedValueException;
 
 use function array_is_list;
 use function array_key_exists;
@@ -306,7 +307,11 @@ private function validateOperations(array $operations, ?DocumentCodec $codec, En
                 case self::INSERT_ONE:
                     // $args[0] was already validated above. Since DocumentCodec::encode will always return a Document
                     // instance, there is no need to re-validate the returned value here.
-                    if ($codec && is_object($args[0])) {
+                    if ($codec) {
+                        if (! is_object($args[0])) {
+                            throw UnsupportedValueException::invalidEncodableValue($args[0]);
+                        }
+
                         $operations[$i][$type][0] = $codec->encode($args[0]);
                     }
 
@@ -341,7 +346,11 @@ private function validateOperations(array $operations, ?DocumentCodec $codec, En
                         throw new InvalidArgumentException(sprintf('Missing second argument for $operations[%d]["%s"]', $i, $type));
                     }
 
-                    if ($codec && is_object($args[1])) {
+                    if ($codec) {
+                        if (! is_object($args[1])) {
+                            throw UnsupportedValueException::invalidEncodableValue($args[1]);
+                        }
+
                         $operations[$i][$type][1] = $codec->encode($args[1]);
                     }
 

src/Operation/FindOneAndReplace.php

@@ -22,6 +22,7 @@
 use MongoDB\Driver\Server;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
+use MongoDB\Exception\UnsupportedValueException;
 
 use function array_key_exists;
 use function is_integer;
@@ -172,6 +173,10 @@ public function getCommandDocument(): array
     private function validateReplacement(array|object $replacement, ?DocumentCodec $codec): array|object
     {
         if ($codec && is_object($replacement)) {
+            if (! is_object($replacement)) {
+                throw UnsupportedValueException::invalidEncodableValue($replacement);
+            }
+
             $replacement = $codec->encode($replacement);
         } elseif (! is_document($replacement)) {
             throw InvalidArgumentException::expectedDocumentType('$replacement', $replacement);

src/Operation/InsertMany.php

@@ -25,6 +25,7 @@
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
+use MongoDB\Exception\UnsupportedValueException;
 use MongoDB\InsertManyResult;
 
 use function array_is_list;
@@ -190,7 +191,11 @@ private function validateDocuments(array $documents, ?DocumentCodec $codec): arr
         }
 
         foreach ($documents as $i => $document) {
-            if ($codec && is_object($document)) {
+            if ($codec) {
+                if (! is_object($document)) {
+                    throw UnsupportedValueException::invalidEncodableValue($document);
+                }
+
                 $documents[$i] = $codec->encode($document);
             } elseif (! is_document($document)) {
                 throw InvalidArgumentException::expectedDocumentType(sprintf('$documents[%d]', $i), $document);

src/Operation/InsertOne.php

@@ -25,6 +25,7 @@
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
+use MongoDB\Exception\UnsupportedValueException;
 use MongoDB\InsertOneResult;
 
 use function is_bool;
@@ -157,7 +158,11 @@ private function createExecuteOptions(): array
 
     private function validateDocument(array|object $document, ?DocumentCodec $codec): array|object
     {
-        if ($codec && is_object($document)) {
+        if ($codec) {
+            if (! is_object($document)) {
+                throw UnsupportedValueException::invalidEncodableValue($document);
+            }
+
             $document = $codec->encode($document);
         } elseif (! is_document($document)) {
             throw InvalidArgumentException::expectedDocumentType('$document', $document);

src/Operation/ReplaceOne.php

@@ -22,6 +22,7 @@
 use MongoDB\Driver\Server;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
+use MongoDB\Exception\UnsupportedValueException;
 use MongoDB\UpdateResult;
 
 use function is_object;
@@ -120,7 +121,11 @@ public function execute(Server $server): UpdateResult
 
     private function validateReplacement(array|object $replacement, ?DocumentCodec $codec): array|object
     {
-        if ($codec && is_object($replacement)) {
+        if ($codec) {
+            if (! is_object($replacement)) {
+                throw UnsupportedValueException::invalidEncodableValue($replacement);
+            }
+
             $replacement = $codec->encode($replacement);
         } elseif (! is_document($replacement)) {
             throw InvalidArgumentException::expectedDocumentType('$replacement', $replacement);