BSONDocument should allow property access by default

Property access, which was already enabled on unserialization, allows code to work with the model as it would the driver's default stdClass

Author: jmikola

src/Model/BSONDocument.php

@@ -16,6 +16,19 @@
  */
 class BSONDocument extends ArrayObject implements Serializable, Unserializable
 {
+    /**
+     * Constructor.
+     *
+     * This overrides the parent constructor to allow property access of entries
+     * by default.
+     *
+     * @see http://php.net/arrayobject.construct
+     */
+    public function __construct($input = [], $flags = ArrayObject::ARRAY_AS_PROPS, $iterator_class = 'ArrayIterator')
+    {
+        parent::__construct($input, $flags, $iterator_class);
+    }
+
     /**
      * Serialize the document to BSON.
      *
@@ -35,6 +48,6 @@ public function bsonSerialize()
      */
     public function bsonUnserialize(array $data)
     {
-        self::__construct($data, ArrayObject::ARRAY_AS_PROPS);
+        parent::__construct($data, ArrayObject::ARRAY_AS_PROPS);
     }
 }

tests/Model/BSONDocumentTest.php

@@ -7,6 +7,13 @@
 
 class BSONDocumentTest extends TestCase
 {
+    public function testConstructorDefaultsToPropertyAccess()
+    {
+        $document = new BSONDocument(['foo' => 'bar']);
+        $this->assertEquals(ArrayObject::ARRAY_AS_PROPS, $document->getFlags());
+        $this->assertSame('bar', $document->foo);
+    }
+
     public function testBsonSerializeCastsToObject()
     {
         $data = [0 => 'foo', 2 => 'bar'];