Skip to content

Commit f8b4e79

Browse files
GromNaNjmikola
andauthored
Apply suggestions from code review
Co-authored-by: Jeremy Mikola <[email protected]>
1 parent 2cd6387 commit f8b4e79

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

tests/UnifiedSpecTests/Context.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ private function createSession(string $id, stdClass $o): void
463463

464464
private function createBucket(string $id, stdClass $o): void
465465
{
466-
Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions', 'disableMD5']);
466+
Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions']);
467467

468468
$databaseId = $o->database ?? null;
469469
assertIsString($databaseId);

tests/UnifiedSpecTests/Util.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ final class Util
134134
'delete' => ['id'],
135135
'downloadByName' => ['filename', 'revision'],
136136
'download' => ['id'],
137+
// "disableMD5" is ignored but allowed for backward compatibility
137138
'uploadWithId' => ['id', 'filename', 'source', 'chunkSizeBytes', 'disableMD5', 'metadata'],
138139
'upload' => ['filename', 'source', 'chunkSizeBytes', 'disableMD5', 'metadata'],
139140
],

0 commit comments

Comments
 (0)