Apply suggestions from code review

GromNaN · jmikola · web-flow · commit f8b4e79678ff · 2024-11-04T14:54:22.000+01:00
Co-authored-by: Jeremy Mikola &lt;jmikola@gmail.com&gt;
diff --git a/tests/UnifiedSpecTests/Context.php b/tests/UnifiedSpecTests/Context.php
@@ -463,7 +463,7 @@ private function createSession(string $id, stdClass $o): void
 
     private function createBucket(string $id, stdClass $o): void
     {
-        Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions', 'disableMD5']);
+        Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions']);
 
         $databaseId = $o->database ?? null;
         assertIsString($databaseId);
diff --git a/tests/UnifiedSpecTests/Util.php b/tests/UnifiedSpecTests/Util.php
@@ -134,6 +134,7 @@ final class Util
             'delete' => ['id'],
             'downloadByName' => ['filename', 'revision'],
             'download' => ['id'],
+            // "disableMD5" is ignored but allowed for backward compatibility
             'uploadWithId' => ['id', 'filename', 'source', 'chunkSizeBytes', 'disableMD5', 'metadata'],
             'upload' => ['filename', 'source', 'chunkSizeBytes', 'disableMD5', 'metadata'],
         ],

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,7 @@ private function createSession(string $id, stdClass $o): void`
`463`	`463`
`464`	`464`	`private function createBucket(string $id, stdClass $o): void`
`465`	`465`	`{`
`466`		`- Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions', 'disableMD5']);`
	`466`	`+ Util::assertHasOnlyKeys($o, ['id', 'database', 'bucketOptions']);`
`467`	`467`
`468`	`468`	`$databaseId = $o->database ?? null;`
`469`	`469`	`assertIsString($databaseId);`