PHPLIB-1159: Remove CreateCollection autoIndexId option

Author: jmikola

src/Operation/CreateCollection.php

@@ -47,14 +47,6 @@ final class CreateCollection
      *
      * Supported options:
      *
-     *  * autoIndexId (boolean): Specify false to disable the automatic creation
-     *    of an index on the _id field. For replica sets, this option cannot be
-     *    false. The default is true.
-     *
-     *    This option has been deprecated since MongoDB 3.2. As of MongoDB 4.0,
-     *    this option cannot be false when creating a replicated collection
-     *    (i.e. a collection outside of the local database in any mongod mode).
-     *
      *  * capped (boolean): Specify true to create a capped collection. If set,
      *    the size option must also be specified. The default is false.
      *
@@ -123,10 +115,6 @@ final class CreateCollection
      */
     public function __construct(private string $databaseName, private string $collectionName, private array $options = [])
     {
-        if (isset($this->options['autoIndexId']) && ! is_bool($this->options['autoIndexId'])) {
-            throw InvalidArgumentException::invalidType('"autoIndexId" option', $this->options['autoIndexId'], 'boolean');
-        }
-
         if (isset($this->options['capped']) && ! is_bool($this->options['capped'])) {
             throw InvalidArgumentException::invalidType('"capped" option', $this->options['capped'], 'boolean');
         }
@@ -207,10 +195,6 @@ public function __construct(private string $databaseName, private string $collec
             unset($this->options['writeConcern']);
         }
 
-        if (isset($this->options['autoIndexId'])) {
-            trigger_error('The "autoIndexId" option is deprecated and will be removed in version 2.0', E_USER_DEPRECATED);
-        }
-
         if (isset($this->options['pipeline']) && ! is_pipeline($this->options['pipeline'], true /* allowEmpty */)) {
             throw new InvalidArgumentException('"pipeline" option is not a valid aggregation pipeline');
         }
@@ -233,7 +217,7 @@ private function createCommand(): Command
     {
         $cmd = ['create' => $this->collectionName];
 
-        foreach (['autoIndexId', 'capped', 'comment', 'expireAfterSeconds', 'max', 'maxTimeMS', 'pipeline', 'size', 'validationAction', 'validationLevel', 'viewOn'] as $option) {
+        foreach (['capped', 'comment', 'expireAfterSeconds', 'max', 'maxTimeMS', 'pipeline', 'size', 'validationAction', 'validationLevel', 'viewOn'] as $option) {
             if (isset($this->options[$option])) {
                 $cmd[$option] = $this->options[$option];
             }

tests/Operation/CreateCollectionTest.php

@@ -25,7 +25,6 @@ public function testConstructorOptionTypeChecks(array $options): void
     public static function provideInvalidConstructorOptions()
     {
         return self::createOptionDataProvider([
-            'autoIndexId' => self::getInvalidBooleanValues(),
             'capped' => self::getInvalidBooleanValues(),
             'changeStreamPreAndPostImages' => self::getInvalidDocumentValues(),
             'clusteredIndex' => self::getInvalidDocumentValues(),
@@ -47,15 +46,4 @@ public static function provideInvalidConstructorOptions()
             'writeConcern' => self::getInvalidWriteConcernValues(),
         ]);
     }
-
-    public function testAutoIndexIdOptionIsDeprecated(): void
-    {
-        $this->assertDeprecated(function (): void {
-            new CreateCollection($this->getDatabaseName(), $this->getCollectionName(), ['autoIndexId' => true]);
-        });
-
-        $this->assertDeprecated(function (): void {
-            new CreateCollection($this->getDatabaseName(), $this->getCollectionName(), ['autoIndexId' => false]);
-        });
-    }
 }

tests/UnifiedSpecTests/Util.php

@@ -75,7 +75,7 @@ final class Util
         Database::class => [
             'aggregate' => ['pipeline', 'session', 'allowDiskUse', 'batchSize', 'bypassDocumentValidation', 'collation', 'comment', 'explain', 'hint', 'let', 'maxAwaitTimeMS', 'maxTimeMS'],
             'createChangeStream' => ['pipeline', 'session', 'fullDocument', 'resumeAfter', 'startAfter', 'startAtOperationTime', 'batchSize', 'collation', 'maxAwaitTimeMS', 'showExpandedEvents'],
-            'createCollection' => ['collection', 'session', 'autoIndexId', 'capped', 'changeStreamPreAndPostImages', 'clusteredIndex', 'collation', 'expireAfterSeconds', 'indexOptionDefaults', 'max', 'maxTimeMS', 'pipeline', 'size', 'storageEngine', 'timeseries', 'validationAction', 'validationLevel', 'validator', 'viewOn'],
+            'createCollection' => ['collection', 'session', 'capped', 'changeStreamPreAndPostImages', 'clusteredIndex', 'collation', 'expireAfterSeconds', 'indexOptionDefaults', 'max', 'maxTimeMS', 'pipeline', 'size', 'storageEngine', 'timeseries', 'validationAction', 'validationLevel', 'validator', 'viewOn'],
             'dropCollection' => ['collection', 'session'],
             'listCollectionNames' => ['authorizedCollections', 'filter', 'maxTimeMS', 'session'],
             'listCollections' => ['authorizedCollections', 'filter', 'maxTimeMS', 'session'],