PHPLIB-1702: Always consult server encryptedFieldsMap when dropping collections #1742
Conversation
| $client = static::createTestClient(); | ||
|
|
||
| // Ensure the key vault collection is dropped before each test | ||
| $collection = $client->selectCollection('keyvault', 'datakeys', ['writeConcern' => new WriteConcern(WriteConcern::MAJORITY)]); |
There was a problem hiding this comment.
You'll get used to the new name of this method.
| $collection = $client->selectCollection('keyvault', 'datakeys', ['writeConcern' => new WriteConcern(WriteConcern::MAJORITY)]); | |
| $collection = $client->getCollection('keyvault', 'datakeys', ['writeConcern' => new WriteConcern(WriteConcern::MAJORITY)]); |
Why do you need to set the writeConcern, as that doesn't guarantee that all replica are up to date.
There was a problem hiding this comment.
I'm borrowing that from the CSFLE spec tests, which use w:majority for all ops targeting the key vault collection. I reckon it makes little difference for tests, but in a production environment this would ensure that any modifications will persist through a replica set election.
| { | ||
| protected ClientEncryption $clientEncryption; | ||
|
|
||
| public function setUp(): void |
There was a problem hiding this comment.
Both test classes has the same setUp method. They should probably be a single test class with 2 test methods.
There was a problem hiding this comment.
Converted this to a single test file in a new PR.
|
Superseded by #1745 |
3 participants
https://jira.mongodb.org/browse/PHPLIB-1702