PHPLIB-1752 Upgrade to psalm 6.14 #1814
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.x #1814 +/- ##
=========================================
Coverage 87.83% 87.83%
Complexity 3208 3208
=========================================
Files 428 428
Lines 6397 6397
=========================================
Hits 5619 5619
Misses 778 778
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| <InvalidAttribute> | ||
| <code><![CDATA[NoDiscard]]></code> | ||
| <code><![CDATA[NoDiscard]]></code> | ||
| </InvalidAttribute> |
There was a problem hiding this comment.
Psalm doesn't know this new attribute.
GromNaN
force-pushed
the
PHPLIB-1752
branch
3 times, most recently
from
eb1f6b2 to
2d1895b
Compare
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Psalm static analysis tool from version 6.5 to 6.14.2 and updates the PHP version used in CI workflows from 8.2 to 8.5.
Key changes:
- Upgraded Psalm dependency and updated baseline file with new version-specific suppressions
- Added
@psalm-no-seal-propertiesannotations toClientandDatabaseclasses - Updated static analysis workflow to use PHP 8.5
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated Psalm version constraint from 6.5.* to ~6.14.2 |
| psalm-baseline.xml | Updated baseline with new Psalm version and added/removed issue suppressions |
| psalm.xml.dist | Added suppressions for MissingOverrideAttribute and ClassMustBeFinal issues |
| src/Client.php | Added @psalm-no-seal-properties annotation to prevent property sealing |
| src/Database.php | Added @psalm-no-seal-properties annotation to prevent property sealing |
| .github/workflows/static-analysis.yml | Updated PHP version from 8.2 to 8.5 for static analysis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GromNaN
force-pushed
the
PHPLIB-1752
branch
2 times, most recently
from
7505ff7 to
f425faf
Compare
|
Looks like we need to update PHP versions on Evergreen for this to work. I created PHPC-2663 to track this. |
Do we need to run psalm in evergreen? |
We don't -- if you want to remove the psalm requirement before running |
| // Error with StaticCallOnNonStaticToInstanceCallRector | ||
| // https://github.com/rectorphp/rector/issues/9608 | ||
| ->withSkipPath(__DIR__ . '/tests/Builder/BuilderEncoderTest.php') |
There was a problem hiding this comment.
3 participants
Fix PHPLIB-1752