PYTHON-5239 Audit bash scripts for consistency (#2238)

Author: blink1073

.evergreen/combine-coverage.sh

@@ -3,8 +3,7 @@
 # Coverage combine merges (and removes) all the coverage files and
 # generates a new .coverage file in the current directory.
 
-set -o xtrace   # Write all commands first to stderr
-set -o errexit  # Exit the script with error if any of the commands fail
+set -eu
 
 . .evergreen/utils.sh
 

.evergreen/resync-specs.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
-# exit when any command fails
-set -e
+# Resync test files from the specifications repo.
+set -eu
 PYMONGO=$(dirname "$(cd "$(dirname "$0")"; pwd)")
 SPECS=${MDB_SPECS:-~/Work/specifications}
 

.evergreen/run-import-time-test.sh

@@ -1,7 +1,6 @@
 #!/bin/bash
-
-# Don't trace since the URI contains a password that shouldn't show up in the logs
-set -o errexit  # Exit the script with error if any of the commands fail
+# Script run on an ECS host to test MONGODB-AWS.
+set -eu
 
 ############################################
 #            Main Program                  #

.evergreen/run-mongodb-aws-ecs-test.sh

@@ -1,6 +1,5 @@
 #!/bin/bash
-
-set +x          # Disable debug trace
+# Script run on a remote host to test MONGODB-OIDC.
 set -eu
 
 echo "Running MONGODB-OIDC authentication tests on ${OIDC_ENV}..."

.evergreen/run-mongodb-oidc-test.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# Run a test suite that was configured with setup-tests.sh.
 set -eu
 
 SCRIPT_DIR=$(dirname ${BASH_SOURCE:-$0})

.evergreen/run-tests.sh

@@ -1,7 +1,43 @@
 #!/bin/bash
+# Check for regressions in the import time of pymongo.
+set -eu
 
-. .evergreen/scripts/env.sh
-set -x
-export BASE_SHA="$1"
-export HEAD_SHA="$2"
-bash .evergreen/run-import-time-test.sh
+HERE=$(dirname ${BASH_SOURCE:-$0})
+
+source $HERE/env.sh
+
+pushd $HERE/../.. >/dev/null
+
+BASE_SHA="$1"
+HEAD_SHA="$2"
+
+. .evergreen/utils.sh
+
+if [ -z "${PYTHON_BINARY:-}" ]; then
+    PYTHON_BINARY=$(find_python3)
+fi
+
+# Use the previous commit if this was not a PR run.
+if [ "$BASE_SHA" == "$HEAD_SHA" ]; then
+    BASE_SHA=$(git rev-parse HEAD~1)
+fi
+
+function get_import_time() {
+    local log_file
+    createvirtualenv "$PYTHON_BINARY" import-venv
+    python -m pip install -q ".[aws,encryption,gssapi,ocsp,snappy,zstd]"
+    # Import once to cache modules
+    python -c "import pymongo"
+    log_file="pymongo-$1.log"
+    python -X importtime -c "import pymongo" 2> $log_file
+}
+
+get_import_time $HEAD_SHA
+git stash || true
+git checkout $BASE_SHA
+get_import_time $BASE_SHA
+git checkout $HEAD_SHA
+git stash apply || true
+python tools/compare_import_time.py $HEAD_SHA $BASE_SHA
+
+popd >/dev/null

.evergreen/scripts/check-import-time.sh

@@ -1,4 +1,6 @@
 #!/bin/bash
+# Clean up resources at the end of an evergreen run.
+set -eu
 
 HERE=$(dirname ${BASH_SOURCE:-$0})
 
@@ -9,4 +11,4 @@ if [ -f $HERE/env.sh ]; then
 fi
 
 rm -rf "${DRIVERS_TOOLS}" || true
-rm -f ./secrets-export.sh || true
+rm -f $HERE/../../secrets-export.sh || true

.evergreen/scripts/cleanup.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-
+# Configure an evergreen test environment.
 set -eu
 
 # Get the current unique version of this checkout

.evergreen/scripts/configure-env.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
-
 # Download all the task coverage files.
+set -eu
 aws s3 cp --recursive s3://"$1"/coverage/"$2"/"$3"/coverage/ coverage/