Skip to content

Commit 05ce3c1

Browse files
committed
address review
1 parent a27f962 commit 05ce3c1

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

.evergreen/generated_configs/tasks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1043,12 +1043,12 @@ tasks:
10431043
tags: [ocsp, ocsp-rsa]
10441044

10451045
# Oidc tests
1046-
- name: test-auth-oidc-test
1046+
- name: test-auth-oidc-default
10471047
commands:
10481048
- func: run tests
10491049
vars:
10501050
TEST_NAME: auth_oidc
1051-
SUB_TEST_NAME: test
1051+
SUB_TEST_NAME: default
10521052
tags: [auth_oidc]
10531053
- name: test-auth-oidc-azure
10541054
commands:

.evergreen/scripts/configure-env.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ EOT
7878
rm -rf $DRIVERS_TOOLS
7979
BRANCH=master
8080
ORG=mongodb-labs
81+
BRANCH=PYTHON-5196
82+
ORG=blink1073
8183
git clone --branch $BRANCH https://github.com/$ORG/drivers-evergreen-tools.git $DRIVERS_TOOLS
8284

8385
cat <<EOT > ${DRIVERS_TOOLS}/.env

.evergreen/scripts/generate_config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -886,12 +886,12 @@ def create_aws_tasks():
886886

887887
def create_oidc_tasks():
888888
tasks = []
889-
for sub_test in ["test", "azure", "gcp", "eks", "aks", "gke"]:
889+
for sub_test in ["default", "azure", "gcp", "eks", "aks", "gke"]:
890890
vars = dict(TEST_NAME="auth_oidc", SUB_TEST_NAME=sub_test)
891891
test_func = FunctionCall(func="run tests", vars=vars)
892892
task_name = f"test-auth-oidc-{sub_test}"
893893
tags = ["auth_oidc"]
894-
if sub_test != "test":
894+
if sub_test != "default":
895895
tags.append("auth_oidc_remote")
896896
tasks.append(EvgTask(name=task_name, tags=tags, commands=[test_func]))
897897
return tasks

.evergreen/scripts/oidc_tester.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010

1111
def _get_target_dir(sub_test_name: str) -> str:
12-
if sub_test_name == "test":
12+
if sub_test_name == "default":
1313
target_dir = "auth_oidc"
1414
elif sub_test_name.startswith("azure"):
1515
target_dir = "auth_oidc/azure"
@@ -42,11 +42,9 @@ def setup_oidc(sub_test_name: str) -> dict[str, str] | None:
4242
return None
4343

4444
source_file = None
45-
if sub_test_name == "test":
45+
if sub_test_name == "default":
4646
source_file = f"{target_dir}/secrets-export.sh"
47-
elif sub_test_name == "azure-remote":
48-
source_file = "./env.sh"
49-
elif sub_test_name == "gcp-remote":
47+
elif sub_test_name in ["azure-remote", "gcp-remote"]:
5048
source_file = "./secrets-export.sh"
5149
if sub_test_name in K8S_REMOTE_NAMES:
5250
return os.environ.copy()
@@ -58,7 +56,7 @@ def setup_oidc(sub_test_name: str) -> dict[str, str] | None:
5856
write_env("MONGODB_URI", config["MONGODB_URI"])
5957
write_env("DB_IP", config["MONGODB_URI"])
6058

61-
if sub_test_name == "test":
59+
if sub_test_name == "default":
6260
write_env("OIDC_TOKEN_FILE", config["OIDC_TOKEN_FILE"])
6361
write_env("OIDC_TOKEN_DIR", config["OIDC_TOKEN_DIR"])
6462
if "OIDC_DOMAIN" in config:

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ the pages will re-render and the browser will automatically refresh.
247247
- Run `just setup-tests auth_oidc <oidc-test-type>` to set up the OIDC test.
248248
- Run the tests with `just run-tests`.
249249

250-
The supported types are [`test`, `azure`, `gcp`, `eks`, `aks`, and `gke`].
250+
The supported types are [`default`, `azure`, `gcp`, `eks`, `aks`, and `gke`].
251251

252252
### KMS tests
253253

0 commit comments

Comments
 (0)