Skip to content

Commit 11a8cb6

Browse files
committed
address review
1 parent 48afdf6 commit 11a8cb6

File tree

2 files changed

+28
-46
lines changed

2 files changed

+28
-46
lines changed

.evergreen/generated_configs/tasks.yml

Lines changed: 17 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8126,39 +8126,39 @@ tasks:
81268126
TOPOLOGY: sharded_cluster
81278127
PYTHON_VERSION: pypy3.10
81288128
tags: [server-version]
8129-
- name: test-python3.9-noauth-nossl-standalone-cov
8129+
- name: test-python3.9-auth-ssl-standalone-cov
81308130
commands:
81318131
- func: run server
81328132
vars:
8133-
AUTH: noauth
8134-
SSL: nossl
8133+
AUTH: auth
8134+
SSL: ssl
81358135
TOPOLOGY: standalone
81368136
COVERAGE: "1"
81378137
- func: run tests
81388138
vars:
8139-
AUTH: noauth
8140-
SSL: nossl
8139+
AUTH: auth
8140+
SSL: ssl
81418141
TOPOLOGY: standalone
81428142
COVERAGE: "1"
81438143
PYTHON_VERSION: "3.9"
81448144
tags: [server-version]
8145-
- name: test-python3.10-noauth-ssl-replica-set-cov
8145+
- name: test-python3.10-noauth-nossl-replica-set-cov
81468146
commands:
81478147
- func: run server
81488148
vars:
81498149
AUTH: noauth
8150-
SSL: ssl
8150+
SSL: nossl
81518151
TOPOLOGY: replica_set
81528152
COVERAGE: "1"
81538153
- func: run tests
81548154
vars:
81558155
AUTH: noauth
8156-
SSL: ssl
8156+
SSL: nossl
81578157
TOPOLOGY: replica_set
81588158
COVERAGE: "1"
81598159
PYTHON_VERSION: "3.10"
81608160
tags: [server-version]
8161-
- name: test-python3.11-noauth-nossl-standalone-cov
8161+
- name: test-python3.12-noauth-nossl-standalone-cov
81628162
commands:
81638163
- func: run server
81648164
vars:
@@ -8172,52 +8172,36 @@ tasks:
81728172
SSL: nossl
81738173
TOPOLOGY: standalone
81748174
COVERAGE: "1"
8175-
PYTHON_VERSION: "3.11"
8175+
PYTHON_VERSION: "3.12"
81768176
tags: [server-version]
8177-
- name: test-python3.12-noauth-ssl-replica-set-cov
8177+
- name: test-python3.13-auth-ssl-replica-set-cov
81788178
commands:
81798179
- func: run server
81808180
vars:
8181-
AUTH: noauth
8181+
AUTH: auth
81828182
SSL: ssl
81838183
TOPOLOGY: replica_set
81848184
COVERAGE: "1"
81858185
- func: run tests
81868186
vars:
8187-
AUTH: noauth
8187+
AUTH: auth
81888188
SSL: ssl
81898189
TOPOLOGY: replica_set
81908190
COVERAGE: "1"
8191-
PYTHON_VERSION: "3.12"
8191+
PYTHON_VERSION: "3.13"
81928192
tags: [server-version]
8193-
- name: test-python3.13-noauth-nossl-standalone-cov
8193+
- name: test-pypy3.10-noauth-nossl-sharded-cluster
81948194
commands:
81958195
- func: run server
81968196
vars:
81978197
AUTH: noauth
81988198
SSL: nossl
8199-
TOPOLOGY: standalone
8200-
COVERAGE: "1"
8199+
TOPOLOGY: sharded_cluster
82018200
- func: run tests
82028201
vars:
82038202
AUTH: noauth
82048203
SSL: nossl
8205-
TOPOLOGY: standalone
8206-
COVERAGE: "1"
8207-
PYTHON_VERSION: "3.13"
8208-
tags: [server-version]
8209-
- name: test-pypy3.10-noauth-ssl-replica-set
8210-
commands:
8211-
- func: run server
8212-
vars:
8213-
AUTH: noauth
8214-
SSL: ssl
8215-
TOPOLOGY: replica_set
8216-
- func: run tests
8217-
vars:
8218-
AUTH: noauth
8219-
SSL: ssl
8220-
TOPOLOGY: replica_set
8204+
TOPOLOGY: sharded_cluster
82218205
PYTHON_VERSION: pypy3.10
82228206
tags: [server-version]
82238207

.evergreen/scripts/generate_config.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -580,20 +580,18 @@ def create_aws_lambda_variants():
580580

581581
def create_server_version_tasks():
582582
tasks = []
583-
task_types = [(p, "sharded_cluster") for p in ALL_PYTHONS]
584-
for python, topology in zip_cycle(ALL_PYTHONS, ["standalone", "replica_set"]):
585-
task_types.append((python, topology))
586-
for python, topology in task_types:
583+
# Test all pythons with sharded_cluster, auth, and ssl.
584+
task_types = [(p, "sharded_cluster", "auth", "ssl") for p in ALL_PYTHONS]
585+
# Test all combinations of topology, auth, and ssl, with rotating pythons.
586+
for python, topology, auth, ssl in zip_cycle(
587+
ALL_PYTHONS, TOPOLOGIES, ["auth", "noauth"], ["ssl", "nossl"]
588+
):
589+
# Skip the ones we already have.
590+
if topology == "sharded_cluster" and auth == "auth" and ssl == "ssl":
591+
continue
592+
task_types.append((python, topology, auth, ssl))
593+
for python, topology, auth, ssl in task_types:
587594
tags = ["server-version"]
588-
if topology == "standalone":
589-
auth = "noauth"
590-
ssl = "nossl"
591-
elif topology == "replica_set":
592-
auth = "noauth"
593-
ssl = "ssl"
594-
else:
595-
auth = "auth"
596-
ssl = "ssl"
597595
expansions = dict(AUTH=auth, SSL=ssl, TOPOLOGY=topology)
598596
if python not in PYPYS:
599597
expansions["COVERAGE"] = "1"

0 commit comments

Comments
 (0)